-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to tomcat.py #12889
Update to tomcat.py #12889
Conversation
-Added "force" (default false) option commensurate with force option in salt.modules.tomcat.deploy_war to allow forced deployment of a .war even if the version strings match. -Forced successful deploy comment to be a string instead of dict to compensate for saltstack#12840
Test Failed. If the failures are unrelated to your code, don't stress, a core developer will know these apart. |
@@ -53,6 +53,7 @@ def __virtual__(): | |||
# Functions | |||
def war_deployed(name, | |||
war, | |||
force, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
force
should be set to False
by-default to be compatible with previous sls files
Test Failed. If the failures are unrelated to your code, don't stress, a core developer will know these apart. |
Thanks for the catch @ranl, I will clean this up :) |
Thanks, Thomas. |
It looks like these changes didn't make it into 2014.1.5 |
That's true. If you want to make sure something makes it into the next release, please ping me (@basepi) on the thread and ask me to cherry-pick it. I've labeled this so it will go into 2014.1.6. |
-Added "force" (default false) option commensurate with force option in salt.modules.tomcat.deploy_war to allow forced deployment of a .war even if the version strings match.
-Forced successful deploy comment to be a string instead of dict to compensate for #12840