Lookup VPC security groups anywhere VPC resources are used #15504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
| log.debug('security group contents {0} pre-conversion'.format(groups)) | ||
| group_ids = [] | ||
| for group in groups: | ||
| if re.match('sg-.*', group): |
There was a problem hiding this comment.
compiling the regex outside of the loop should be a little faster. fnmatch or startswith might also be a little faster. This is not a concern of course :)
thatch45
added a commit
that referenced
this pull request
Sep 4, 2014
Lookup VPC security groups anywhere VPC resources are used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VPC fixes for most of the boto_* modules. This change will translate security group names to security group IDs for VPC resources, since AWS requires group IDs when using VPC.