Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing dict key from ec2 response. #15901

Merged
merged 2 commits into from Sep 18, 2014
Merged

Fix missing dict key from ec2 response. #15901

merged 2 commits into from Sep 18, 2014

Conversation

UtahDave
Copy link
Contributor

Fixes #15900

ping @techhat

@UtahDave
Copy link
Contributor Author

@rallytime Do we need some tests for this?

@rallytime rallytime added the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Sep 18, 2014
@rallytime
Copy link
Contributor

Sure. I applied the Needs Testcase label so it doesn't get lost in the shuffle. :)

@ghost
Copy link

ghost commented Sep 18, 2014

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/8121/

@techhat
Copy link
Contributor

techhat commented Sep 18, 2014

I'm seeing the same thing, and this looks to fix it. Thanks @UtahDave!

techhat added a commit that referenced this pull request Sep 18, 2014
Fix missing dict key from ec2 response.
@techhat techhat merged commit c1dfc61 into saltstack:2014.7 Sep 18, 2014
@UtahDave UtahDave deleted the 2014.7local branch September 18, 2014 15:47
@techhat
Copy link
Contributor

techhat commented Sep 21, 2014

@UtahDave, this seems to have causes a regression; sometimes that key exists, and sometimes it does not. Will update when I have more info.

A fix for #15931 will also have to be posted when I have this worked out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants