Cloud: Check the exit status code of scp before assuming it has failed.

[akatrevorjay]

Latest 2014.1 broke salt-cloud due to this. With this small patch I can deploy instances again.

[ghost]

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/9103/

[awestendorf]

Can you please release a package with this fix in it ASAP? salt-cloud is currently broken, and trying to use the fix in #16437 doesn't work because even with use_sftp: False, sftp is used and then fails.

[cachedout]

HI Aaron. We had passing tests on 2014.1.12. Is that the version that
you're seeing salt-cloud failures on?

On Tue, Oct 14, 2014 at 8:59 AM, Aaron Westendorf notifications@github.com
wrote:

Can you please release a package with this fix in it ASAP? salt-cloud is
currently broken, and trying to use the fix in #16437
#16437 doesn't work because
even with use_sftp: False, sftp is used and then fails.

—
Reply to this email directly or view it on GitHub
#16599 (comment).

[akatrevorjay]

@cachedout I saw this problem in 2014.1.12 as well.

[cachedout]

@akaihola OK. Thanks for letting us know.

[techhat]

Got stung by this today too. Moving back to 2014.1.10 took care of me.