Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module.run state for non-dict return data #16981

Merged
merged 1 commit into from Oct 30, 2014

Conversation

terminalmage
Copy link
Contributor

This backports part of a fix for this that is already in the 2014.7 branch,
properly handling execution module functions which return non-dict data.

This backports part of a fix for this that is already in the 2014.7
branch, properly handling execution module functions which return
non-dict data.
@cachedout
Copy link
Contributor

I was under the impression that there would be no more 2014.1 releases. Is that incorrect?

@terminalmage
Copy link
Contributor Author

Yeah, I don't think we will, but I figured that in the unlikely event we do, we can at least get this one fixed.

@ghost
Copy link

ghost commented Oct 28, 2014

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/9516/

thatch45 added a commit that referenced this pull request Oct 30, 2014
Fix module.run state for non-dict return data
@thatch45 thatch45 merged commit aa7d97c into saltstack:2014.1 Oct 30, 2014
@garthk
Copy link

garthk commented Nov 6, 2014

I think I'm running into this with tls.create_self_signed_cert:

      ID: default-key
Function: module.run
    Name: tls.create_self_signed_cert
  Result: False
 Comment: An exception occurred in this state: Traceback (most recent call last):
            File "/usr/lib/python2.7/dist-packages/salt/state.py", line 1382, in call
              **cdata['kwargs'])
            File "/usr/lib/python2.7/dist-packages/salt/states/module.py", line 203, in run
              if ret['changes'].get('ret', {}).get('retcode', 0) != 0:
          AttributeError: 'str' object has no attribute 'get'

How can I track progress toward this fix being available via apt-get with the official repo? I'm on 2014.1.13+ds-1trusty1.

@cachedout
Copy link
Contributor

Hi @garthk. The next release of salt, 2014.7 is currently being packaged and should be available in the repos in the next several days.

@terminalmage terminalmage deleted the module-run-fix-2014.1 branch December 11, 2014 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants