typo and using 'in' #193
Merged
typo and using 'in' #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Markus Gattol <markus.gattol@sunoano.org>
|
2.6 is the targeted language, yes. As for the in syntax, I don't know that this should be a required style change in all of the code. |
arthurzenika
pushed a commit
to arthurzenika/salt
that referenced
this pull request
Sep 17, 2013
Adding salt.exceptions to mock
dwoz
pushed a commit
to dwoz/salt
that referenced
this pull request
Mar 16, 2021
[3002.6] Fixes unit.setup.test_install.InstallTest.test_sdist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Thomas,
I am staring to grind my teeth into salt... just polishing stuff that springs my eyes for now. Question: we're targeting 2.6+ for now so I figure you're fine with switching stuff from using
has_key()toinyes?