Fix multi-master event handling bug #19790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 16, 2015 10:33
We had a situation wherein minion generators would race to the sub socket and only a single minion would actually act on the package. The result was that events such as refresh_pillar would cause one (or sometimes both) minions to stop responding. This changes the behaviour so that the first instance to get the request calls action on all instances. While this has the possible side-effect of blocking for O(n) inside the event handling loop, it also ensures that multi-master minions update in a linear fashion.
|
Go Go Jenkins! |
thatch45
added a commit
that referenced
this pull request
Jan 17, 2015
Fix multi-master event handling bug
|
@cachedout is this something that should be backported to 2014.7? |
rallytime
added
the
bugfix-bckport
This was referenced Jan 22, 2015
rallytime
added
ZZZ[Done]-back-ported-bf
rallytime
pushed a commit
that referenced
this pull request
Jan 23, 2015
thatch45
added a commit
that referenced
this pull request
Jan 23, 2015
Revert "Backport #19790 to 2014.7"
|
It appears that when the previous attempt at a backport was reverted, I never backported this change to 2015.2. The above PR remedies that. |
cro
pushed a commit
to cro/salt
that referenced
this pull request
Feb 28, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a situation wherein minion generators would race to the sub
socket and only a single minion would actually act on the package. The
result was that events such as refresh_pillar would cause one (or
sometimes both) minions to stop responding. This changes the behaviour
so that the first instance to get the request calls action on all
instances.
While this has the possible side-effect of blocking for O(n) inside the event
handling loop, it also ensures that multi-master minions update in a
linear fashion.