(DO NOT MERGE) Aptpkg support version comparisons #19791

ryan-lane · 2015-01-16T17:49:57Z

Fixes #19480. Enables support for version comparison operators

ryan-lane · 2015-01-16T17:50:42Z

This PR has an issue. When using '>=mypackage-1.2-1' apt-get install fails with:

E: Unable to locate package "mypackage">

This has something to do with how subprocess is running the command. When I switched to using cmd.run with python_shell=True and a single string as the param it ran without issues.

jfindlay · 2015-01-16T18:22:29Z

@ryan-lane, I think _parse_version could be better handled by querying dpkg-query -W -f rather than regexping the default format, something like

pkg_data = __salt__['cmd.run']('dpkg-query -W -f "${binary:Package} ${Version}\n" {0}'.format(' '.join(pkgs)))
pkg_dict = {}
for pkg in pkg_data:
    pkg_name, pkg_version = pkg.split()
    pkg_dict[pkg_name] = pkg_version
    # etc.

I'm not sure where the artifacts in your query strings are coming from, but in my experience package managers are picky about how their queries are formatted.

jfindlay · 2015-01-16T18:29:03Z

I just realized that you're parsing the version requirements, '>', '=', '<', etc. so you can disregard my comment about dpkg-query, unless it can parse requirements somehow, which I doubt.

ryan-lane · 2015-01-27T02:20:20Z

Ping. Anyone have any ideas here? I'd really like this to work, but am stuck with the subprocess issue.

cachedout · 2015-01-27T02:22:09Z

Re-ping of @terminalmage who might have some good insight here. I will also try and take a look at this tomorrow.

terminalmage · 2015-01-27T18:03:41Z

@ryan-lane Can you post the debug logging from the command that is being run? Particularly I am interested in the list of args being passed to cmd.run.

terminalmage · 2015-01-27T18:12:52Z

Also, are you sure this even works?

root@ubuntu:~# apt-get install 'apt-utils>=2.4.2'
Reading package lists... Done
Building dependency tree
Reading state information... Done
E: Unable to locate package apt-utils>

ryan-lane · 2015-01-27T21:03:53Z

It does if you do:

apt-get install apt-utils>=2.4.2

If you wrap it in quotes it fails.
On Jan 27, 2015 10:13 AM, "Erik Johnson" notifications@github.com wrote:

Also, are you sure this even works?

root@ubuntu:~# apt-get install 'apt-utils>=2.4.2'
Reading package lists... Done
Building dependency tree
Reading state information... Done
E: Unable to locate package apt-utils>

—
Reply to this email directly or view it on GitHub
#19791 (comment).

terminalmage · 2015-01-27T21:29:33Z

root@ubuntu:~# apt-get install apt-utils>=2.4.2
root@ubuntu:~# ls -l
total 4
-rw-r--r-- 1 root root 578 Jan 27 21:28 =2.4.2

terminalmage · 2015-01-27T21:36:48Z

@ryan-lane I don't think this is working the way you believe it is working. It appears to simply be running an apt-get install and redirecting output (see below). This results in an upgrade (as it would anyway, if available), leading you to believe that it worked when it did not.

Running with python_shell=False makes python not run the command in a shell, meaning that it will not interpret things like I/O redirection, shell expansion, and other characters with special meaning to the shell (like &).

root@ubuntu:~# apt-get install bash>4.3-7ubuntu1.4
root@ubuntu:~# cat 4.3-7ubuntu1.4
Reading package lists...
Building dependency tree...
Reading state information...
The following packages were automatically installed and are no longer required:
  dctrl-tools dmidecode git git-man liberror-perl libjs-jquery libpgm-5.1-0
  libyaml-0-2 libzmq3 python-async python-crypto python-git python-gitdb
  python-jinja2 python-m2crypto python-mako python-markupsafe python-msgpack
  python-smmap python-yaml python-zmq rsync
Use 'apt-get autoremove' to remove them.
Suggested packages:
  bash-doc
Recommended packages:
  bash-completion
The following packages will be upgraded:
  bash
1 upgraded, 0 newly installed, 0 to remove and 60 not upgraded.
Need to get 576 kB of archives.
After this operation, 0 B of additional disk space will be used.
Get:1 http://archive.ubuntu.com/ubuntu/ trusty-updates/main bash amd64 4.3-7ubuntu1.5 [576 kB]
Fetched 576 kB in 0s (1,106 kB/s)
(Reading database ... 25002 files and directories currently installed.)
Preparing to unpack .../bash_4.3-7ubuntu1.5_amd64.deb ...
Unpacking bash (4.3-7ubuntu1.5) over (4.3-7ubuntu1.4) ...
Processing triggers for man-db (2.6.7.1-1ubuntu1) ...
Setting up bash (4.3-7ubuntu1.5) ...
update-alternatives: using /usr/share/man/man7/bash-builtins.7.gz to provide /usr/share/man/man7/builtins.7.gz (builtins.7.gz) in auto mode

ryan-lane · 2015-01-27T21:45:11Z

Hm. lame. I guess I'll change this to only support =, > and >= and compare the versions internally. Thanks for the help!

terminalmage · 2015-01-27T21:56:49Z

@ryan-lane No, I don't think that will work, because I don't think that anything besides = is supported in APT. Any usage of angle brackets will be assumed to be input/output redirection. This is why you're getting the error when python_shell=False. If apt-get install supported that syntax, you would not be getting that error.

I wrote the version pinning support in aptpkg.py originally, and specifically only permitted specific versions (i.e. pkgname=version) for that reason.

In order to support version comparison like in other providers, we would need to get all available versions of the package and then include logic to install the newest available version which satisfies the version comparison expression.

I wrote a list_repo_pkgs function in yumpkg.py which can list all available versions of a given package, organized by repository. A similar function in aptpkg.py could be used to find the available versions. Once a suitable version which matches the comparison expression is found, it can be installed using the existing method (i.e. pkgname=version).

ryan-lane · 2015-01-27T22:24:00Z

If you run apt-get install package, it will always install the newest package available. If you only support =, > and >= you can avoid apt-get update if package is >= than the version specified. If there isn't a newer package available and the version specified is greater than the version installed you fail. It's possible to do it without finding all available packages.

Mostly what I'm aiming for is the ability to do >= a known secure package without needing to do an apt-get upgrade every time.

terminalmage · 2015-01-27T22:54:46Z

OK, so the idea would be to see if the current version fulfills that version comparison? What would you do in the event that a version matching the comparison expression was already installed?

ryan-lane · 2015-01-27T22:57:58Z

Return true :)

terminalmage · 2015-01-27T23:27:01Z

That would be a bad idea, since pkg.install does not return a bool.

ryan-lane · 2015-01-27T23:32:11Z

I'd return the comparison between old and new, which would be the same.

terminalmage · 2015-01-27T23:35:22Z

OK, I just wanted to make sure you weren't returning a bool. 😄

thatch45 · 2015-02-06T17:17:49Z

@ryan-lane what is the status here? Should we close this out pending a new PR?

ryan-lane · 2015-02-06T17:48:42Z

We're going to followup in the same PR. Most of the code changes in here are still needed. It's just one part that needs to be fixed.

thatch45 · 2015-03-17T23:56:45Z

What is the status here? This PR has been sitting in limbo for a while. Can we close it? Should it stay in limbo for another month?
@ryan-lane

ryan-lane · 2015-03-18T00:52:06Z

I guess let's close it out for now. I'll push another PR later when I have
this working. I haven't been able to prioritize this lately.

On Tue, Mar 17, 2015 at 4:57 PM, Thomas S Hatch notifications@github.com
wrote:

What is the status here? This PR has been sitting in limbo for a while.
Can we close it? Should it stay in limbo for another month?

—
Reply to this email directly or view it on GitHub
#19791 (comment).

cachedout · 2015-03-18T14:50:14Z

Closed per @ryan-lane

Ryan Lane added 2 commits January 12, 2015 15:29

Add check_extra_requirements to aptpkg

43ab945

Add version comparison to install

b3e396e

thatch45 added the Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged label Feb 6, 2015

jfindlay mentioned this pull request Mar 12, 2015

support apt >= option #21584

Closed

cachedout closed this Mar 18, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(DO NOT MERGE) Aptpkg support version comparisons #19791

(DO NOT MERGE) Aptpkg support version comparisons #19791

ryan-lane commented Jan 16, 2015

ryan-lane commented Jan 16, 2015

jfindlay commented Jan 16, 2015

jfindlay commented Jan 16, 2015

ryan-lane commented Jan 27, 2015

cachedout commented Jan 27, 2015

terminalmage commented Jan 27, 2015

terminalmage commented Jan 27, 2015

ryan-lane commented Jan 27, 2015

terminalmage commented Jan 27, 2015

terminalmage commented Jan 27, 2015

ryan-lane commented Jan 27, 2015

terminalmage commented Jan 27, 2015

ryan-lane commented Jan 27, 2015

terminalmage commented Jan 27, 2015

ryan-lane commented Jan 27, 2015

terminalmage commented Jan 27, 2015

ryan-lane commented Jan 27, 2015

terminalmage commented Jan 27, 2015

thatch45 commented Feb 6, 2015

ryan-lane commented Feb 6, 2015

thatch45 commented Mar 17, 2015

ryan-lane commented Mar 18, 2015

cachedout commented Mar 18, 2015

(DO NOT MERGE) Aptpkg support version comparisons #19791

(DO NOT MERGE) Aptpkg support version comparisons #19791

Conversation

ryan-lane commented Jan 16, 2015

ryan-lane commented Jan 16, 2015

jfindlay commented Jan 16, 2015

jfindlay commented Jan 16, 2015

ryan-lane commented Jan 27, 2015

cachedout commented Jan 27, 2015

terminalmage commented Jan 27, 2015

terminalmage commented Jan 27, 2015

ryan-lane commented Jan 27, 2015

terminalmage commented Jan 27, 2015

terminalmage commented Jan 27, 2015

ryan-lane commented Jan 27, 2015

terminalmage commented Jan 27, 2015

ryan-lane commented Jan 27, 2015

terminalmage commented Jan 27, 2015

ryan-lane commented Jan 27, 2015

terminalmage commented Jan 27, 2015

ryan-lane commented Jan 27, 2015

terminalmage commented Jan 27, 2015

thatch45 commented Feb 6, 2015

ryan-lane commented Feb 6, 2015

thatch45 commented Mar 17, 2015

ryan-lane commented Mar 18, 2015

cachedout commented Mar 18, 2015