GH-16780: add hardlink function to file exec/state modules #20428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@atbell this is a feature addition and should be made to the develop branch please |
|
Hey @tankywoo, I totally forgot to re-open this for |
|
@Pravka Cool 👍 |
|
@Pravka any update? This one is still closed but doesn't seem to have been merged so far and the original issue is also still open... Thanks (urgently needed) |
|
Since this appeared to have been dropped. I implemented PR #55000 which is based on this PR. Hopefully it gets merged. Writing the unit tests for new features (especially states) is probably one of the most painful things in the world. I want graphs in saltstack. |
arizvisa
added a commit
to arizvisa/saltstack-salt
that referenced
this pull request
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change resolves #16780, adding a
hardlinkfunction to thefilestate and execution modules. It makes does not perform any mount point checking, thus assumes that the operator knows if thetargetanddestreside on the same filesystem (it will throw anOSErrorif an attempt is made to create a hard link across devices).