Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #20198: virt.get_graphics and virt.get_nics calls in module virt #21469

Merged
merged 2 commits into from
Mar 10, 2015
Merged

fixes #20198: virt.get_graphics and virt.get_nics calls in module virt #21469

merged 2 commits into from
Mar 10, 2015

Conversation

vdesjardins
Copy link
Contributor

No description provided.

@rallytime
Copy link
Contributor

Thanks for putting this fix together, @vdesjardins!

Refs #20198

@rallytime rallytime added the bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch label Mar 10, 2015
@rallytime
Copy link
Contributor

I have marked this pull request for back-porting, but, in the future, feel free to make bug-fixes against the earliest supported branch (that's 2014.7 right now) that needs the fix. Then, we will merge the changes forward so the fix can be present on all of the affected branches. Don't worry about this one, we will get it, but just for future reference.

We're happy to answer any questions about this workflow, or you can also read up on it here: http://docs.saltstack.com/en/latest/topics/development/contributing.html#id1

Thanks again!

@rallytime
Copy link
Contributor

Also, thanks very much for writing a test!

@rallytime
Copy link
Contributor

@vdesjardins Mind grabbing this pylint error really quickly?

https://jenkins.saltstack.com/job/salt-pr-lint-n/2824/violations/file/salt/modules/virt.py/

The other test failure is unrelated.

@vdesjardins
Copy link
Contributor Author

Hi!

No problem for the patch! I'm happy to help where I can.

Thanks for the link on the workflow. I'm going to read it before my next contribution!

@rallytime
Copy link
Contributor

Awesome! Thanks so much!

rallytime pushed a commit that referenced this pull request Mar 10, 2015
Merge pull request #21469 from vdesjardins/develop
827541e 
fixes #20198: virt.get_graphics and virt.get_nics calls in module virt
@rallytime rallytime merged commit 827541e into saltstack:develop Mar 10, 2015
@rallytime rallytime mentioned this pull request Mar 10, 2015
Merged
@rallytime rallytime added ZZZ[Done]-back-ported-bf RETIRED The pull request has been back-ported to an older branch. and removed bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch labels Mar 10, 2015
thatch45 added a commit that referenced this pull request Mar 11, 2015
@thatch45
Merge pull request #21487 from rallytime/bp-21469
4873382 
Backport #21469 to 2014.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ZZZ[Done]-back-ported-bf RETIRED The pull request has been back-ported to an older branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vdesjardins @rallytime