Remove m2crypto #23348
Merged
Remove m2crypto #23348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- RSA key generation and import/export using PyCrypto - PKCS1 v1.5 signature generation and verification using PyCrypto - SHA1 using PyCrypto - RSA ANSI X9.31 signature generation & verification using OpenSSL libcrypto via ctypes Still needed: - rework salt/modules/x509.py - test :)
|
Awesome! |
|
Gah! I was going to apply the AWESOME! |
|
Failures are due to the PyCrypto RNG not being re-initialized after a fork(). Doing this is a one-liner but after looking at the stack traces I'm not sure where to put it. Maybe @cachedout or @thatch45 can help? |
|
+1 |
|
Yes, good call @msteed! PyCrypto needs the RNG to be massaged. Likely in the MWorker in master.py, maybe in the start method |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove M2Crypto as a dependency. Backward-compatible functionality is implemented using PyCrypto and calls into OpenSSL libcrypto.