Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put the sed insert statement back in to the output. #23367

Merged
merged 2 commits into from
May 5, 2015

Conversation

kaithar
Copy link
Contributor

@kaithar kaithar commented May 5, 2015

Turns out that commit a369c88 (merged in PR #18368) make a bad change to modules/makeconf.py where it removed the insertion part of a '/regex/ i\text' construction.

Since this bug's pretty old, Nov 2014, I'll be sending backport PRs momentarily for 2014.7 and 2015.2 branches.

Turns out that commit a369c88 (merged in PR saltstack#18368) make a bad change to modules/makeconf.py where it removed the insertion part of a '/regex/ i\text' construction.
@jfindlay
Copy link
Contributor

jfindlay commented May 5, 2015

@kaithar, thanks for the fix. It is only necessary to submit fixes to the oldest release branch as the branches are merged forward regularly. This also helps to keep our git history a little simpler, see https://docs.saltstack.com/en/latest/topics/development/contributing.html#which-salt-branch.

@jfindlay
Copy link
Contributor

jfindlay commented May 5, 2015

Do you mind if I close this and the pull request against 2015.2?

@jfindlay jfindlay added the Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged label May 5, 2015
@kaithar
Copy link
Contributor Author

kaithar commented May 5, 2015

@jfindlay nod I tried doing it this way as an experiment, following the back port instructions on that page.
I targeted develop primarily because that's what I'm running and this bug was providing an obstruction in my plans for the day. I made the backports because I'd have asked for them anyway. Trying to be helpful :)

@kaithar
Copy link
Contributor Author

kaithar commented May 5, 2015

@jfindlay sure, if it's not going to take too long to promote up to develop 😸

@jfindlay
Copy link
Contributor

jfindlay commented May 5, 2015

@kaithar, no problem. I'll go ahead and merge all these since I've created more work complaining about it than would have been saved. I'm always trying to reevaluate how to better message our workflow, so if you have any comments, please share them, thanks, gentoo ftw, btw!

@jfindlay jfindlay added Minor Change Tests-Passed and removed Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged labels May 5, 2015
jfindlay added a commit that referenced this pull request May 5, 2015
Put the sed insert statement back in to the output.
@jfindlay jfindlay merged commit 3412d55 into saltstack:develop May 5, 2015
jfindlay added a commit that referenced this pull request May 5, 2015
@kaithar
Copy link
Contributor Author

kaithar commented May 6, 2015

@jfindlay heh, seems to be an irony. Thanks for merging.
(Edited to remove annoying redundancy)

@kaithar kaithar deleted the issue/fix-_add_var branch May 6, 2015 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants