-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put the sed insert statement back in to the output. #23367
Conversation
Turns out that commit a369c88 (merged in PR saltstack#18368) make a bad change to modules/makeconf.py where it removed the insertion part of a '/regex/ i\text' construction.
@kaithar, thanks for the fix. It is only necessary to submit fixes to the oldest release branch as the branches are merged forward regularly. This also helps to keep our git history a little simpler, see https://docs.saltstack.com/en/latest/topics/development/contributing.html#which-salt-branch. |
Do you mind if I close this and the pull request against 2015.2? |
@jfindlay nod I tried doing it this way as an experiment, following the back port instructions on that page. |
@jfindlay sure, if it's not going to take too long to promote up to develop 😸 |
@kaithar, no problem. I'll go ahead and merge all these since I've created more work complaining about it than would have been saved. I'm always trying to reevaluate how to better message our workflow, so if you have any comments, please share them, thanks, gentoo ftw, btw! |
Put the sed insert statement back in to the output.
@jfindlay heh, seems to be an irony. Thanks for merging. |
Turns out that commit a369c88 (merged in PR #18368) make a bad change to modules/makeconf.py where it removed the insertion part of a '/regex/ i\text' construction.
Since this bug's pretty old, Nov 2014, I'll be sending backport PRs momentarily for 2014.7 and 2015.2 branches.