Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use abspath, do not eliminating symlinks #23757

Merged
merged 1 commit into from
May 15, 2015

Conversation

clan
Copy link
Contributor

@clan clan commented May 15, 2015

realpath will eliminating symlinks, so following sls won't work as expected

/root/a:
  file.directory:
    - user: root
    - group: root
    - mode: 0755
    - clean: True
    - require:
      - file: /root/a/b

/root/a/b:
  file.symlink:
    - user: root
    - group: root
    - target: /etc

realpath will eliminating symlinks, so following sls won't work as expected

/root/a:
  file.directory:
    - user: root
    - group: root
    - mode: 0755
    - clean: True
    - require:
      - file: /root/a/b

/root/a/b:
  file.symlink:
    - user: root
    - group: root
    - target: /etc
@jfindlay jfindlay added Minor Change Tests-Passed bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch labels May 15, 2015
@jfindlay
Copy link
Contributor

@clan, thanks for the fix. In the future, please feel free to submit fixes directly to the oldest supported release branch that applies, as the release branches are regularly merged forward, see https://docs.saltstack.com/en/latest/topics/development/contributing.html#which-salt-branch.

jfindlay added a commit that referenced this pull request May 15, 2015
use abspath, do not eliminating symlinks
@jfindlay jfindlay merged commit d7ce64f into saltstack:develop May 15, 2015
@jfindlay
Copy link
Contributor

This change can go all the way back to 2014.7.

@rallytime rallytime added ZZZ[Done]-back-ported-bf RETIRED The pull request has been back-ported to an older branch. and removed bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch labels May 16, 2015
@clan clan deleted the file_directory_require branch May 18, 2015 02:43
jfindlay added a commit that referenced this pull request May 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tests-Passed ZZZ[Done]-back-ported-bf RETIRED The pull request has been back-ported to an older branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants