Fix pacman.list_upgrades for new python_shell default. #24490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2015.5 sets the default for python_shell to False, so the pipe used in pacman.list_upgrades no longer works. The egrep invocation after the pipe has the effect of skipping the first output line, which is an informational message. Instead of piping to egrep, we simply skip the first line of output when parsing for the available upgrades.
rallytime
added
Minor Change
Tests-Passed
Platform
thatch45
added a commit
that referenced
this pull request
Jun 9, 2015
Fix pacman.list_upgrades for new python_shell default.
|
Very nice! Thanks! |
|
Fixes #23667 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2015.5 sets the default for python_shell to False, so the pipe used in
pacman.list_upgrades no longer works. The egrep invocation after the
pipe has the effect of skipping the first output line, which is an
informational message. Instead of piping to egrep, we simply skip the
first line of output when parsing for the available upgrades.