Don't modify empty change #24986
Merged
Don't modify empty change #24986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinta
added
Core
|
@heewa Thanks for the PR! |
cachedout
added
Platform
|
@jtand This should have the |
|
Yes, this should have the platform label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a
pkg.installstate, if there wasn't a change (like from an error), the "hold" logic tries to modify the change for a package it had held, but since there isn't one, a key error is raised, aborting the rest of the install logic, and showing the user an unhelpful code traceback.This PR fixes this issue by leaving an empty change dict alone.