Don't try to cache a template when it's not a file #24987
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to use
file.managed
without a source file, justcontents
, with templating,modules/file.py
tries to cache the template itself, but in this case it's not a file, so an Exception is raised when it tries to do string stuff to aNone
, which gets caught and turned into a confusing string error, shown to the user.This PR fixes this issue by avoiding trying to cache a nonexistent file.