Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #25016 #25020

Merged
merged 1 commit into from
Jun 29, 2015
Merged

Fix for issue #25016 #25020

merged 1 commit into from
Jun 29, 2015

Conversation

martinhoefling
Copy link
Contributor

Remove iteration over returned minions which is done a couple of lines before in the same function.

@martinhoefling
Copy link
Contributor Author

The failed build seems to be a jenkins / ssh issue.

@martinhoefling
Copy link
Contributor Author

Can sb. take a look into the failures? They seem to be unrelated to the commit.

@jfindlay jfindlay added Core relates to code central or existential to Salt Minor Change Tests-Passed Runners bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch labels Jun 27, 2015
@jfindlay
Copy link
Contributor

@martinhoefling, thanks for the fix. Next time you are welcome to submit fixes directly to the oldest supported release branch, see https://docs.saltstack.com/en/latest/topics/development/contributing.html#which-salt-branch.

@martinhoefling
Copy link
Contributor Author

On 28.06.15 00:47, Justin Findlay wrote:

@martinhoefling, thanks for the fix. Next time you are welcome to submit fixes directly to the oldest supported release branch, see https://docs.saltstack.com/en/latest/topics/development/contributing.html#which-salt-branch.

Damn! Forgot about that...

Best wishes

Martin

@jfindlay
Copy link
Contributor

No problem, thanks for your work on this.

cachedout pushed a commit that referenced this pull request Jun 29, 2015
@cachedout cachedout merged commit cfd904d into saltstack:develop Jun 29, 2015
@rallytime rallytime added ZZZ[Done]-back-ported-bf RETIRED The pull request has been back-ported to an older branch. and removed bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch labels Jul 6, 2015
jfindlay added a commit that referenced this pull request Jul 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core relates to code central or existential to Salt Runners Tests-Passed ZZZ[Done]-back-ported-bf RETIRED The pull request has been back-ported to an older branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants