Switch Scaleway to salt.utils.cloud.bootstrap()

[techhat]

@edouardb, could you please take a look?

[edouardb]

vm_ doesn't exist should be server_, same thing for next occurrences

[edouardb]

ip_address is not defined should be assigned from data['public_ip']['address']

if data.get('public_ip') is not None:
  ip_address = data['public_ip']['address']

[edouardb]

Hi @techhat,

After fixing the code I run some test on the create function and I get the following error:

Error: There was a query error: Cannot deploy salt in a VM if the 'ssh_keyfile' setting is not set and there is no password set for the vm. Check your provider for the 'change_password' option.

Any idea why?

Thanks

[techhat]

@edouardb, fixed. Do you have any comments on ssh_password or ssh_keyfile? One or both needs to be specified, and I didn't see either in your code.

[techhat]

@edouardb check my other question to you, it should answer your question to me.

[edouardb]

Right! 😄

You can keep ssh_password which is not required by default as we use key but it can be useful to have both.

I re-run the test adding key_filename instead of ssh_keyfile in my config and everything is fine.

Thanks 👍

[techhat]

@edouardb ssh_key or ssh_keyfile?

[edouardb]

@techhat ssh_keyfile

[edouardb]

Line 209 and 384, 'provider': server_['provider'] must be changed to 'driver' : server_['driver'] to prevent salt to raise the following exception:

[ERROR   ] Failed to create VM XXX. Configuration value 'provider' needs to be set
Traceback (most recent call last):
  File "/root/salt/salt/cloud/__init__.py", line 1256, in create
    output = self.clouds[func](vm_)
  File "/root/salt/salt/cloud/clouds/scaleway.py", line 209, in create
    'provider': server_['provider'],
KeyError: 'provider'

and

[ERROR   ] Failed to create VM XXX. Configuration value 'provider' needs to be set
Traceback (most recent call last):
  File "/root/salt/salt/cloud/__init__.py", line 1256, in create
    output = self.clouds[func](vm_)
  File "/root/salt/salt/cloud/clouds/scaleway.py", line 384, in create
    'provider': server_['provider'],
KeyError: 'provider'

[rallytime]

@edouardb Thanks for testing this. Those stacktraces should be fixed in #25575 that I've referenced above.

[rallytime]

Go Go Jenkins!

[techhat]

Thanks @rallytime. Please hold off on merging for a moment, @edouardb and I are still working on the ssh_keyfile issue.

[techhat]

I have been unable to reproduce this issue. In fact, without this code I can spin up a machine but not provision it, but with this code, the machine is provisioned.