patchelf lives in pkgsrc

[sjorge]

alteast on base-64-lts 14.4.0 release, no need download the binary from elsewhere.

[jfindlay]

@sjorge, thanks for the fix. In the future you are welcome to submit fixes directly to the oldest supported release branch, see https://docs.saltstack.com/en/latest/topics/development/contributing.html#which-salt-branch.

@nshalman

[sjorge]

Should probably go in 2014.7 too then, not much use in 2015.x branches currently cut as both are broken on SmartOS.

[nshalman]

+1 from me. I'm pretty sure patchelf wasn't in the pkgsrc builds I was using when I first did this work, but it is now so this is a definite improvement.

I also agree that it should ideally land in 2014.7 and get merged up to the other branches.

[jfindlay]

Thanks, @sjorge, @nshalman. We need to get SmartOS supported again on recent releases. Do either of you have specific enough information to file one or more issues on this? Have issues been filed for broken SmartOS support? @BretFisher, @fractaluniverse, and @johngrasty have recently been active on SmartOS issues with salt-bootstrap and may have additional input.

[nshalman]

@jfindlay I haven't had a chance to look into the Esky issue, but to summarize an email thread with @dmurphy18:

@nshalman:

Something in 2015.5 doesn't seem to like being packaged in an Esky and I haven't had a chance to debug it...

@dmurphy18:

There is a problem with the use of decorators in the lazy loader where inspect.getmodule is not returning a module.
Found this with the 2015.5 branch, but have not had time to research a solution for the issue yet.
./salt/utils/decorators/__init__.py line 62
Found issues researching on Google about use of @decorator syntax and not using index 1 but 2 when inspecting the stack.
I have tried replacing the __init__.py file without the benefit of esky and the problem still occurred.
However esky could be affecting other files. BTW: python used was python 2.7.10.

My understanding is that @johngrasty was able to use salt-bootstrap to do a git based install of the 2015.5 branch.
I'm pretty sure that Joyent's pkgsrc builds package some version, but doesn't track as aggressively as I was tracking with my Esky builds.

[jfindlay]

@nshalman, would you mind opening an issue with that info so we can track it? Thanks.

[sjorge]

The find_library stuff in salt/utils/rsax931.py in 2015.8 also is broken on SmartOS esky package (maybe more as it tries to look for the system library, which is probably not available)

[nshalman]

I've opened #25756.

[jfindlay]

Thanks @nshalman.

[sjorge]

Also made one for the find_library stuff in 2015.8 #25757