Fix httpasswd result false positive in test mode

[anlutro]

httpasswd.user_exists currently always shows up as having changed something if ran with test=True.

          ID: phpmyadmin-htpasswd
    Function: webutil.user_exists
        Name: admin
      Result: None
     Comment: User already known
     Started: 15:16:10.324431
    Duration: 4.742 ms
     Changes:

[jfindlay]

@anlutro, is it possible to fix this in another way since the state system relies on the result being None in test mode?

[jfindlay]

#25721.

[anlutro]

There might be an underlying issue I'm missing, but my impression is that "no change" should be represented as True regardless of test mode or not. Similar issue: #25978

[anlutro]

The current behaviour of returning None was added here: b23c0fa#diff-acd69d8f060effeb82071b575ddee9bbR84

[jfindlay]

ret['result'] for state functions is a tristate, where True means 'the change was successful/changes made', False: 'not successful/no changes', and None: test mode. I do not know if this is formally documented somewhere yet, but there is this: #25143.

[jfindlay]

@anlutro, see #26032.

[anlutro]

If that's correct then the other pull request I made with a similar change
should probably be reverted, and the highstate outputter changed, as true
is the only value that shows up as no change for me...

On Wed, 5 Aug 2015 17:37 Justin Findlay notifications@github.com wrote:

@anlutro https://github.com/anlutro, see #26032
#26032.

—
Reply to this email directly or view it on GitHub
#26026 (comment).

[jfindlay]

@anlutro, I think so, yes. I have expanded the results documentation again, correctly this time, I hope: #26042.

[anlutro]

I'll take a closer look later tonight, hard to do on the phone!

On Wed, 5 Aug 2015 19:36 Justin Findlay notifications@github.com wrote:

@anlutro https://github.com/anlutro, I think so, yes. I have expanded
the results documentation again, correctly this time, I hope: #26042
#26042.

—
Reply to this email directly or view it on GitHub
#26026 (comment).

[jfindlay]

Sure, thank you for your work on these issues.

[anlutro]

@jfindlay thanks for the clarification in the docs. I think my change is still correct.

If at any point in the function there are any changes, there will have been an early return. The changes I made are at a place in the code where no changes have been made, so True should be returned regardless of whether salt is in test mode or not.

It looks to me like the author of b23c0fa thought you were supposed to return None if there were no changes in test mode.

[jfindlay]

@anlutro, you are correct. My understanding of ret['result'] was incorrect a few hours ago, but hopefully the documentation changes in #26042 make it clearer.

[anlutro]

Speaking as someone who wasn't clear on what it meant before, it definitely does. Cheers!