Fix Windows failures in pip module due to raw string formatting #26617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to pass lists of args to cmd.* without having to do type checking beforehand to make sure they're lists.
|
Test failures are due to changing list of command arguments. I will update these (and fix the lint errors) later tonight. |
Also made a number of formatting fixes
|
OK, tests have been updated and the module now passes the args to Please don't merge yet, I want to do manual testing in the morning before I am comfortable signing off on it. |
justinta
added
Execution-Module
Windows
Platform
|
Just closing until you do your manual testing. Since tests passed someone could accidentally merge this. =) |
|
OK, manual testing went fine, I just ended up making one change unrelated to the rest of the changes to ensure that we return a useful error when non-list input is specified for pip.installed's "pkgs" argument. |
basepi
added a commit
that referenced
this pull request
Aug 27, 2015
Fix Windows failures in pip module due to raw string formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9592.