S3 ext_pillar module has broken caching mechanism #26953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dsumsky
commented
Sep 8, 2015
dsumsky
commented
- fixed broken caching in S3 ext_pillar module (file_md5 was a list)
- added debugging messages
- static parameters are available as module parameters now
- added debugging messages - static parameters are available as module parameters now
jfindlay
added
Medium Change
Pillar
RIoT
|
@dsumsky, thanks for the fix. Do you think this needs to be in 2015.5 or 2015.8? |
|
I also created pull request for 2015.5 version tree. |
|
@dsumsky Thanks! It looks like you have some pylint errors. Would you mind grabbing those? |
|
Go Go Jenkins! |
rallytime
pushed a commit
to rallytime/salt
that referenced
this pull request
Sep 10, 2015
rallytime
pushed a commit
that referenced
this pull request
Sep 10, 2015
Merge #26953 with Pylint fix
rallytime
added
the
ZZZ[Done]-back-ported-bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.