salt/master: chdir to root not homedir #27091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pre-flight checks try to change to $HOME, this can fail for multiple reasons. One such case is that /root is a protected dir under SELinux which the master should not have access to. The daemon should instead change to the root dir which is the only dir that is always guaranteed to be there. The limited testing I have managed to do shows that windows accepts the '/' path too just fine so the os-specific case is not required either.
jfindlay
added
Core
|
I'm willing to merge this for now, but it needs extensive testing across all platforms so I'd like to let it run the full test suite across additional distros and see how things go. Thanks! |
cachedout
pushed a commit
that referenced
this pull request
Sep 14, 2015
salt/master: chdir to root not homedir
|
@twangboy Now that this is merged, please verify that your Windows installs still operate correctly. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pre-flight checks try to change to $HOME, this can fail for multiple
reasons. One such case is that /root is a protected dir under SELinux
which the master should not have access to. The daemon should instead
change to the root dir which is the only dir that is always guaranteed
to be there. The limited testing I have managed to do shows that windows
accepts the '/' path too just fine so the os-specific case is not
required either.
Changing to $HOME was added in #21279
Gentoo-Bug: https://bugs.gentoo.org/560300