Make sure -Q output is consistent across salt-cloud drivers #27110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 14, 2015 14:28
rallytime
added
Salt-Cloud
Medium Change
RIoT
| @@ -184,10 +184,36 @@ def list_nodes(call=None): | |||
| while fetch: | |||
| items = query(method='droplets', command='?page=' + str(page) + '&per_page=200') | |||
| for node in items['droplets']: | |||
| networks = node['networks'] | |||
| v4s = networks.get('v4', None) | |||
There was a problem hiding this comment.
You do not need the second None. It is an implied default.
|
@rallytime A tiny bit of cleanup here and we'll be set. Thanks! |
cachedout
added
the
pending-changes
rallytime
removed
the
pending-changes
cachedout
pushed a commit
that referenced
this pull request
Sep 14, 2015
Make sure -Q output is consistent across salt-cloud drivers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11993