Boto dynamodb module should be using layer 2 abstractions #27119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
boto_dynamodb
module was using the layer1 abstractions after the refactor toutils.boto
. It originally was using the layer2 abstractions: 5f7bd48Noticed this after trying to run:
salt 'salt-master' boto_dynamodb.exists salt-master-store
This returned:
salt-master: Passed invalid arguments to boto_dynamodb.exists: list indices must be integers, not str Check to see if a table exists. CLI Example: .. code-block:: bash salt myminion boto_dynamodb.exists table_name region=us-east-1
This was due to the layer1 abstractions that return a list of tables instead of a dictionary (which the salt module was expecting). With the layer2 abstraction change was tested successfully against
create_table
,exist
anddelete
in theboto_dynamodb
module:Salt versions: