Add a configurable timer for minion return retries #27286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a minion return cannot be processed in a timely manner, a SaltReqTimeoutError is raised. However, the default wait time before the minion will retry sending the return data was not being passed, so it would wait a full 60 seconds. This reduces that timeout to (by default) a maximum of 4 seconds, and randomizes it to prevent a retry flood as you scale up the number of minions.
terminalmage
force-pushed
the
return_retry_timer
branch
from
39e732e
to
540a7df
Compare
jfindlay
added
Core
cachedout
pushed a commit
that referenced
this pull request
Sep 22, 2015
Add a configurable timer for minion return retries
jacksontj
added a commit
to jacksontj/salt
that referenced
this pull request
Nov 7, 2015
This feature originally would randomize between 1 -> return_retry_timer, which meant you could always had the possibility of haing a return retry with a timeout of 1s. This change maxes both ends of the range configurable (similar to how acceptance_wait_time is configured). In addition I've added coverage in the minion configuration documentation. Cleanup of saltstack#27286 Fixes saltstack#28577
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a minion return cannot be processed in a timely manner, a
SaltReqTimeoutError is raised. However, the default wait time before the
minion will retry sending the return data was not being passed, so it
would wait a full 60 seconds.
This reduces that timeout to (by default) a maximum of 4 seconds, and
randomizes it to prevent a retry flood as you scale up the number of
minions.