Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version reporting of python-gnupg and mysql-python #27466

Merged
merged 2 commits into from Sep 28, 2015

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Sep 28, 2015

The module is called gnupg, not python-gnupg.

Without this, the version for python-gnupg will not show up with
salt-call --versions-report.

While looking at it, I've found the ('mysql-python', 'mysql-python', '__version__') to look suspicious, too. I have not tested it, but it should be fixed now, too.

The module is called `gnupg`, not `python-gnupg`.

Without this, the version for `python-gnupg` will not show up with
`salt-call --versions-report`.
The module is called `MySQLdb`, not `mysql-python`.

Without this, the version for `mysql-python` will not show up with
`salt-call --versions-report`.
@jfindlay jfindlay added Core relates to code central or existential to Salt Minor Change labels Sep 28, 2015
@cachedout
Copy link
Contributor

Nice catch!

cachedout pushed a commit that referenced this pull request Sep 28, 2015
Fix version reporting of python-gnupg and mysql-python
@cachedout cachedout merged commit 9202f95 into saltstack:2015.8 Sep 28, 2015
@blueyed blueyed deleted the fix-gnupg-version branch September 28, 2015 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core relates to code central or existential to Salt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants