Add missing return data to scheduled jobs (#24237) #30246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4237) * Instead of ignoring the execution of jobs with invalid function names, continue, so that always some data is returned. * Move the code that returns data to the master to the 'finally' section, so that data is returned also in case of error. * Set a default 'success' value, and overwrite it with the value from the function context.
|
This all looks pretty solid to me. Thanks, @dmacvicar I'd like to first cc: @garethgreenaway on this one for some additional review though before we get this in. |
cachedout
added
the
Pending-Discussion
|
@cachedout looks good. |
|
I'm going to go ahead and merge this. Looks really good. @jacobhammons This might be a nice feature to highlight in the release notes. |
cachedout
pushed a commit
that referenced
this pull request
Jan 13, 2016
Add missing return data to scheduled jobs (#24237)
cachedout
added
Release-Notes
and removed
Pending-Discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scheduled jobs miss
successandretcode, as described in #24237This PR refactors the job execution so that:
retcodeis setretevent backsuccessFalse by capturing exceptions and sending the event back even in the error casesuccessfalseFeedback welcome.