Fix lsscsi issues for certain platforms #30659
Conversation
| @@ -14,7 +15,7 @@ | |||
| } | |||
|
|
|||
|
|
|||
| def ls_(): | |||
| def ls_(get_size=True): | |||
| ''' | |||
| List SCSI devices, with details | |||
|
|
|||
There was a problem hiding this comment.
Can you add a definition for get_size here, as well as a .. versionadded:: 2015.5.10 directive for that new kwarg?
There was a problem hiding this comment.
Oops, yup, sorry about that. I'll get that added today.
|
This gets the 👍 from me. Once the docstring is updated we can merge. |
basepi
added
the
pending-changes
The lsscsi command doesn't support the '-s' flag on any RHEL/CentOs system until RHEL7. The command now have an option to specify 'get_size' to enable compatibility with the older platforms. Also fixes some issues with lsscsi not being installed and exceptions getting thrown because of that.
|
Updated the documentation - though looks like the test for ubuntu bailed. Is there a way to re-run the jenkins tests without having to push a fake update? :) |
rallytime
removed
the
pending-changes
|
@sjmh This looks great! Thanks for making those changes. One of the reasons we run these tests on multiple platforms on pull requests is for situations like this - if the test minion doesn't get provisioned/bootstrapped correctly, we can still see results of the run on another platform, so we're all good here. Thank you! |
Fix lsscsi issues for certain platforms
The lsscsi command doesn't support the '-s' flag on any RHEL/CentOs system until RHEL7.
The command now has an option to specify 'get_size' to enable compatibility with the older platforms.
Also fixes some issues with lsscsi not being installed and exceptions getting thrown because of that.
Fixes #30565, needs to be ported to 2015.8 as well.