Make sure we use the "instance" kwarg in cloud.action. #30691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rallytime
changed the title
|
Go Go Jenkins! |
cachedout
pushed a commit
that referenced
this pull request
Jan 29, 2016
Make sure we use the "instance" kwarg in cloud.action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29602
Related to #30217.
In #30217, the original stacktrace as reported in #29602 was fixed in regards to
cloud/__init__.pyhandling kwargs in action calls, but usinginstance=my-instance provider=my-providerwith the cloud runner also didn't work, as "instance" was never used in the cloud runner action function. This PR fixes using "instance" and also provides helpful error logging information when the incorrect parameters are used in combination. Namely, you can't use an instance with a list of names together or instance/names combined with a provider.ping @techhat and @pass-by-value