Make sure setting list_user_permissions to ['', '', ''] doesn't stacktrace #30822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this failing test is fixed. @rallytime will rebase. |
added 2 commits
February 2, 2016 12:46
When attempting to reproduce the bug in saltstack#28971, the pyobjects rederer errors and doesn't output the state properly when a set() is returned via the rabbitmq_user._check_tags_changes function. This change fixes that error and state output appears as intended.
…trace And doesn't report changes on secondary state runs. Fixes saltstack#28971
rallytime
force-pushed
the
rabbitmq-user-state-fixes
branch
from
449706f
to
272cc65
Compare
|
Done. |
cachedout
pushed a commit
that referenced
this pull request
Feb 2, 2016
Make sure setting list_user_permissions to ['', '', ''] doesn't stacktrace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And doesn't report changes on secondary state runs. Also fixed a bug in the state return when checking for new tags in rabbitmq_user state.
Fixes #28971