Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils.aws: use time lib to conver to epoch seconds #30849

Merged
merged 1 commit into from Feb 3, 2016
Merged

utils.aws: use time lib to conver to epoch seconds #30849

merged 1 commit into from Feb 3, 2016

Conversation

jfindlay
Copy link
Contributor

@jfindlay jfindlay commented Feb 3, 2016

Fixes #30798.

@jfindlay jfindlay added Salt-Cloud RIoT Relates to integration with cloud providers, hypervisors, API-based services, etc. labels Feb 3, 2016
@techhat
Copy link
Contributor

techhat commented Feb 3, 2016

How about int(time.time())?

@cachedout cachedout added the Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged label Feb 3, 2016
@jfindlay
Copy link
Contributor Author

jfindlay commented Feb 3, 2016

@techhat, I think that that value is timezone 'naive', which would throw off a check of 120 seconds difference. Whereas time.mktime(datetime.utcnow().timetuple()) is guaranteed to be UTC.

@techhat
Copy link
Contributor

techhat commented Feb 3, 2016

@jfindlay, makes sense, wasn't thinking.

cachedout pushed a commit that referenced this pull request Feb 3, 2016
Merge pull request #30849 from jfindlay/aws_seconds
276cf62 
utils.aws: use time lib to conver to epoch seconds
@cachedout cachedout merged commit 276cf62 into saltstack:2015.8 Feb 3, 2016
@cachedout
Copy link
Contributor

Thanks all.

@jfindlay jfindlay deleted the aws_seconds branch February 19, 2016 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged RIoT Relates to integration with cloud providers, hypervisors, API-based services, etc. Salt-Cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jfindlay @techhat @cachedout