Backport #30797 to 2015.8 #30888
Merged
Backport #30797 to 2015.8 #30888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unit tests now test for the bug fixed in the previous commit (among other things).
Before, if the driver parameter wasn't specified, the dockerng state module's volume_present() function would try to delete the volume and recreate it. Now it simply ignores the existing volume's driver setting and returns success. Note that this change assumes that if the driver is unspecified then the user means "I don't care what the driver is", not "I care that the driver matches the Docker default".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #30797
so this fix will be in the next release of 2015.8