Fix regression when contents_pillar/contents_grains is a list. #31026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if isinstance(item, six.string_types): | ||
| ret.append(item) | ||
| else: | ||
| ret.append(str(item)) |
There was a problem hiding this comment.
why this change? is calling str() on every item too expensive, or does it have side effects we don't like? Mostly curious.
There was a problem hiding this comment.
It throws exceptions in Python 2 if the string is unicode and contains unicode characters which can't be decoded to ascii.
WORKS FINE
>>> str(u'foo')
'foo'KILLS KITTENS
>>> str(u'Д')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
UnicodeEncodeError: 'ascii' codec can't encode character u'\u0414' in position 0: ordinal not in range(128)
>>>There was a problem hiding this comment.
fascinating. Good to know, thanks.
basepi
added a commit
that referenced
this pull request
Feb 9, 2016
Fix regression when contents_pillar/contents_grains is a list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #30934.