Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saltcloud virtualbox provider #31058

Merged
merged 245 commits into from
Feb 18, 2016
Merged

Saltcloud virtualbox provider #31058

merged 245 commits into from
Feb 18, 2016

Commits on Sep 13, 2015

  1. Herp derp frist!

    @LoveIsGrief
    LoveIsGrief committed Sep 13, 2015
    Configuration menu
    Copy the full SHA
    80e1f2c View commit details
    Browse the repository at this point in the history

  2. Add more bones to the create() function skeleton

    @LoveIsGrief
    LoveIsGrief committed Sep 13, 2015
    Configuration menu
    Copy the full SHA
    bf40ee5 View commit details
    Browse the repository at this point in the history

  3. Simple tests to get a feel of the virtualbox api 

    These aren't unit tests (yet)
    @LoveIsGrief
    LoveIsGrief committed Sep 13, 2015
    Configuration menu
    Copy the full SHA
    b7998f7 View commit details
    Browse the repository at this point in the history

  4. The Virtualbox SDK ref 

    No need to go online and search for it
    @LoveIsGrief
    LoveIsGrief committed Sep 13, 2015
    Configuration menu
    Copy the full SHA
    790dacf View commit details
    Browse the repository at this point in the history

  5. Got a README, mate?

    @LoveIsGrief
    LoveIsGrief committed Sep 13, 2015
    Configuration menu
    Copy the full SHA
    aad27af View commit details
    Browse the repository at this point in the history

  6. Initial commit

    @LoveIsGrief
    LoveIsGrief committed Sep 13, 2015
    Configuration menu
    Copy the full SHA
    58c779e View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/master'

    @LoveIsGrief
    LoveIsGrief committed Sep 13, 2015
    Configuration menu
    Copy the full SHA
    314d743 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2015

  1. A little more documentation 

    Also get rid of keys we don't need in the provider config
    @LoveIsGrief
    LoveIsGrief committed Sep 26, 2015
    Configuration menu
    Copy the full SHA
    6c3077d View commit details
    Browse the repository at this point in the history

  2. Only allow us to clone VMs (for now)

    @LoveIsGrief
    LoveIsGrief committed Sep 26, 2015
    Configuration menu
    Copy the full SHA
    632d4de View commit details
    Browse the repository at this point in the history

  3. Fill the virtual name for salt-cloud

    @LoveIsGrief
    LoveIsGrief committed Sep 26, 2015
    Configuration menu
    Copy the full SHA
    9547071 View commit details
    Browse the repository at this point in the history

  4. Debug line: is virtualbox configured for salt-cloud?

    @LoveIsGrief
    LoveIsGrief committed Sep 26, 2015
    Configuration menu
    Copy the full SHA
    d08079b View commit details
    Browse the repository at this point in the history

  5. Use correct variable (copy-pasted from linode.py :\

    @LoveIsGrief
    LoveIsGrief committed Sep 26, 2015
    Configuration menu
    Copy the full SHA
    4bdf407 View commit details
    Browse the repository at this point in the history

  6. Logs to let the user know why stuff fails

    @LoveIsGrief
    LoveIsGrief committed Sep 26, 2015
    Configuration menu
    Copy the full SHA
    69f80d4 View commit details
    Browse the repository at this point in the history

  7. PEP8 linting

    @LoveIsGrief
    LoveIsGrief committed Sep 26, 2015
    Configuration menu
    Copy the full SHA
    8c5391f View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2015

  1. Move out basic virtualbox functions and introduce basic tests

    @LoveIsGrief
    LoveIsGrief committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    005e2f8 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2015

  1. Ignore pycharm files

    @LoveIsGrief
    LoveIsGrief committed Oct 11, 2015
    Configuration menu
    Copy the full SHA
    b2d7435 View commit details
    Browse the repository at this point in the history

  2. Fix some lint errors

    @LoveIsGrief
    LoveIsGrief committed Oct 11, 2015
    Configuration menu
    Copy the full SHA
    428ac1e View commit details
    Browse the repository at this point in the history

  3. We need a pass

    @LoveIsGrief
    LoveIsGrief committed Oct 11, 2015
    Configuration menu
    Copy the full SHA
    a6292ed View commit details
    Browse the repository at this point in the history

  4. Make the logs a little clearer

    @LoveIsGrief
    LoveIsGrief committed Oct 11, 2015
    Configuration menu
    Copy the full SHA
    889d0e1 View commit details
    Browse the repository at this point in the history

  5. Create a basic VirtualBoxTestCase with helper assertions

    @LoveIsGrief
    LoveIsGrief committed Oct 11, 2015
    Configuration menu
    Copy the full SHA
    d59247d View commit details
    Browse the repository at this point in the history

  6. Introduce a method to help us create VMs 

    (not clones)
    @LoveIsGrief
    LoveIsGrief committed Oct 11, 2015
    Configuration menu
    Copy the full SHA
    1834dff View commit details
    Browse the repository at this point in the history

  7. Improve tests 

    Test VM creation, destruction and cloning
    @LoveIsGrief
    LoveIsGrief committed Oct 11, 2015
    Configuration menu
    Copy the full SHA
    e58416e View commit details
    Browse the repository at this point in the history

  8. De-linting

    @LoveIsGrief
    LoveIsGrief committed Oct 11, 2015
    Configuration menu
    Copy the full SHA
    7a5eb6a View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2015

  1. Ignore the log directory created by tests

    @LoveIsGrief
    LoveIsGrief committed Oct 17, 2015
    Configuration menu
    Copy the full SHA
    7335500 View commit details
    Browse the repository at this point in the history

  2. Moar information

    @LoveIsGrief
    LoveIsGrief committed Oct 17, 2015
    Configuration menu
    Copy the full SHA
    c8a74e2 View commit details
    Browse the repository at this point in the history

  3. Merge with https://github.com/LoveIsGrief/saltcloud-virtualbox-provider

    @LoveIsGrief
    LoveIsGrief committed Oct 17, 2015
    Configuration menu
    Copy the full SHA
    a1d9588 View commit details
    Browse the repository at this point in the history

  4. Post-merge organization

    @LoveIsGrief
    LoveIsGrief committed Oct 17, 2015
    Configuration menu
    Copy the full SHA
    4c5b5d3 View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2015

  1. Merge branch 'develop' of https://github.com/saltstack/salt into salt… 

    …-27089
    @LoveIsGrief
    LoveIsGrief committed Dec 25, 2015
    Configuration menu
    Copy the full SHA
    ec8c6f9 View commit details
    Browse the repository at this point in the history

  2. Add basic configuration for the tests 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Dec 25, 2015
    Configuration menu
    Copy the full SHA
    4cbc641 View commit details
    Browse the repository at this point in the history

  3. Move around files for clarity and separation 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Dec 25, 2015
    Configuration menu
    Copy the full SHA
    b3d76b8 View commit details
    Browse the repository at this point in the history

  4. Setup testing for calls to salt-cloud 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Dec 25, 2015
    Configuration menu
    Copy the full SHA
    f547936 View commit details
    Browse the repository at this point in the history

  5. PEP8 docstrings 

    double quotes instead of single quotes

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Dec 25, 2015
    Configuration menu
    Copy the full SHA
    ce494b6 View commit details
    Browse the repository at this point in the history

  6. Add virtualbox to profile checks 

    Virtualbox needs the 'clonefrom' property and it doesn't need size

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Dec 25, 2015
    Configuration menu
    Copy the full SHA
    691e521 View commit details
    Browse the repository at this point in the history

  7. Remove unnecessary import 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Dec 25, 2015
    Configuration menu
    Copy the full SHA
    96d1956 View commit details
    Browse the repository at this point in the history

  8. More rigorous setup precautions for tests 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Dec 25, 2015
    Configuration menu
    Copy the full SHA
    1dea2d3 View commit details
    Browse the repository at this point in the history

  9. Set default log level to INFO 

    Fix log lines

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Dec 25, 2015
    Configuration menu
    Copy the full SHA
    36a9486 View commit details
    Browse the repository at this point in the history

  10. Use the constants for testing 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Dec 25, 2015
    Configuration menu
    Copy the full SHA
    adf653e View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2015

  1. Return a dict from an XPCOM object 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Dec 26, 2015
    Configuration menu
    Copy the full SHA
    a5b950c View commit details
    Browse the repository at this point in the history

  2. Unit tests for xpcomt to dict conversion 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Dec 26, 2015
    Configuration menu
    Copy the full SHA
    0a78753 View commit details
    Browse the repository at this point in the history

  3. A log line y'all! 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Dec 26, 2015
    Configuration menu
    Copy the full SHA
    92df434 View commit details
    Browse the repository at this point in the history

  4. Test creating a virtual machine with salt-cloud 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Dec 26, 2015
    Configuration menu
    Copy the full SHA
    ebef604 View commit details
    Browse the repository at this point in the history

  5. Make creating a virtual machine work 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Dec 26, 2015
    Configuration menu
    Copy the full SHA
    f49ea26 View commit details
    Browse the repository at this point in the history

  6. Code formatting 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Dec 26, 2015
    Configuration menu
    Copy the full SHA
    205954b View commit details
    Browse the repository at this point in the history

  7. Check existence without an exception 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Dec 26, 2015
    Configuration menu
    Copy the full SHA
    d71b3e7 View commit details
    Browse the repository at this point in the history

  8. move vbox to its own function 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Dec 26, 2015
    Configuration menu
    Copy the full SHA
    1ccef7c View commit details
    Browse the repository at this point in the history

  9. Organize imports a little 

    This will allow us to import the provider in e.g a virtualenv without doing too much PYTHONPATH fuckery

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Dec 26, 2015
    Configuration menu
    Copy the full SHA
    bd480ae View commit details
    Browse the repository at this point in the history

  10. List all available images in virtualbox 

    Does virtualbox have templates?

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Dec 26, 2015
    Configuration menu
    Copy the full SHA
    34dc009 View commit details
    Browse the repository at this point in the history

  11. Move virtualbox functions to their own utility module 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Dec 26, 2015
    Configuration menu
    Copy the full SHA
    fc8a826 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2015

  1. Implement instance destruction 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Dec 27, 2015
    Configuration menu
    Copy the full SHA
    ed3b306 View commit details
    Browse the repository at this point in the history

  2. Oops, that doesn't belong there... 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Dec 27, 2015
    Configuration menu
    Copy the full SHA
    1b0524a View commit details
    Browse the repository at this point in the history

  3. Remove some TODOs 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Dec 27, 2015
    Configuration menu
    Copy the full SHA
    8ba7f53 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2016

  1. Remove list_available_images 

    Following a discussion about it, the function just doesn't apply to virtualbox
virtalbox doesn't have a concept of "templates" so we can't list them

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 2, 2016
    Configuration menu
    Copy the full SHA
    fbe3e77 View commit details
    Browse the repository at this point in the history

  2. Ignore test log files 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 2, 2016
    Configuration menu
    Copy the full SHA
    fa75206 View commit details
    Browse the repository at this point in the history

  3. Ignore private keys generated by integration tests 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 2, 2016
    Configuration menu
    Copy the full SHA
    2b44d1f View commit details
    Browse the repository at this point in the history

  4. Improve XPCOM to dict conversion 

    We will need this in the future when listing machines and requesting attributes that don't exist (yet)

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 2, 2016
    Configuration menu
    Copy the full SHA
    55a7398 View commit details
    Browse the repository at this point in the history

  5. Improve XPCOM to dict conversion 

    Allow passing tuples of attributes and their default values in case they don't exist in the xpcom object

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 2, 2016
    Configuration menu
    Copy the full SHA
    565a7f8 View commit details
    Browse the repository at this point in the history

  6. Output the default information expected for list_nodes 

    This still needs to be enriched

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 2, 2016
    Configuration menu
    Copy the full SHA
    555c668 View commit details
    Browse the repository at this point in the history

  7. A small TODO 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 2, 2016
    Configuration menu
    Copy the full SHA
    249da52 View commit details
    Browse the repository at this point in the history

  8. Improve the output of list_nodes 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 2, 2016
    Configuration menu
    Copy the full SHA
    d64dc20 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2016

  1. Tests and templates for starting and stopping VMs 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 3, 2016
    Configuration menu
    Copy the full SHA
    b4de152 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2016

  1. Output a human-readable machine state 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 4, 2016
    Configuration menu
    Copy the full SHA
    12327d8 View commit details
    Browse the repository at this point in the history

  2. Red-test: list_nodes_full 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 4, 2016
    Configuration menu
    Copy the full SHA
    743f4e1 View commit details
    Browse the repository at this point in the history

  3. Green-test: list_nodes_full 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 4, 2016
    Configuration menu
    Copy the full SHA
    4b0f7c3 View commit details
    Browse the repository at this point in the history

  4. Implement function show_image 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 4, 2016
    Configuration menu
    Copy the full SHA
    0d32094 View commit details
    Browse the repository at this point in the history

  5. Refactoring and code clean up 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 4, 2016
    Configuration menu
    Copy the full SHA
    b2fdf33 View commit details
    Browse the repository at this point in the history

  6. Implement list_nodes_select 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 4, 2016
    Configuration menu
    Copy the full SHA
    0e750c8 View commit details
    Browse the repository at this point in the history

  7. A little PEP8 cleaning 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 4, 2016
    Configuration menu
    Copy the full SHA
    1a0dca9 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2016

  1. A simpler version of list_nodes_select 

    Reuse helper

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 5, 2016
    Configuration menu
    Copy the full SHA
    abb3de5 View commit details
    Browse the repository at this point in the history

  2. First version to get network adresses from guest 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 5, 2016
    Configuration menu
    Copy the full SHA
    50db0b9 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2016

  1. Use dict output for VirtualboxTests 

    This should make the output from salt-cloud more verifiable and make tests more reliable

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 6, 2016
    Configuration menu
    Copy the full SHA
    e2a7cbd View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2016

  1. First test to get network address from already running guest 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 9, 2016
    Configuration menu
    Copy the full SHA
    ee746ff View commit details
    Browse the repository at this point in the history

  2. Move some common test functions to helpers 

    Introduce stop machine test (it's red :( )

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 9, 2016
    Configuration menu
    Copy the full SHA
    52e927d View commit details
    Browse the repository at this point in the history

  3. Provider is getting deprecated in the config 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 9, 2016
    Configuration menu
    Copy the full SHA
    fdbe9f4 View commit details
    Browse the repository at this point in the history

  4. Force actions in tests 

    Otherwise there is always a confirmation prompt... ain't nobody got time fo' dat!

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 9, 2016
    Configuration menu
    Copy the full SHA
    3569a2d View commit details
    Browse the repository at this point in the history

  5. Green-test: VirtualboxProviderHeavyTests::test_stop_action 

    We can now tell instances to stop

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 9, 2016
    Configuration menu
    Copy the full SHA
    5a0e45d View commit details
    Browse the repository at this point in the history

  6. Use common function to output machines 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 9, 2016
    Configuration menu
    Copy the full SHA
    887e8a4 View commit details
    Browse the repository at this point in the history

  7. A function doc 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 9, 2016
    Configuration menu
    Copy the full SHA
    bb89198 View commit details
    Browse the repository at this point in the history

  8. Starting machines works now too 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 9, 2016
    Configuration menu
    Copy the full SHA
    54f4c94 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2016

  1. Try and stop the running VM as a cleanup 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 10, 2016
    Configuration menu
    Copy the full SHA
    6bd66ac View commit details
    Browse the repository at this point in the history

  2. Remove unneeded test 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 10, 2016
    Configuration menu
    Copy the full SHA
    27515c3 View commit details
    Browse the repository at this point in the history

  3. Improve documentation a little and fix warnings 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 10, 2016
    Configuration menu
    Copy the full SHA
    b10c540 View commit details
    Browse the repository at this point in the history

  4. Get real number of slots for VM 

    Before it was theoretical, now it's real (a response from a query the VM, not the hypervisor settings)

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 10, 2016
    Configuration menu
    Copy the full SHA
    470d790 View commit details
    Browse the repository at this point in the history

  5. Helper functions should do what they are named for 

    New helpers also added to describe the state of the machine

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 10, 2016
    Configuration menu
    Copy the full SHA
    e60d262 View commit details
    Browse the repository at this point in the history

  6. New function for ip addresses 

    Waits on the guest to have one.

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 10, 2016
    Configuration menu
    Copy the full SHA
    076e73a View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2016

  1. Improve output JSON interpretation cleaning for tests 

    (Actually also fix it because we we popping increasing random elements from the output... not good)

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 23, 2016
    Configuration menu
    Copy the full SHA
    4f1e5c4 View commit details
    Browse the repository at this point in the history

  2. Improve doc 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 23, 2016
    Configuration menu
    Copy the full SHA
    9bde4e4 View commit details
    Browse the repository at this point in the history

  3. Feature: deploy salt on machine when creating 

    We need to setup the tests with a profile that wants to deploy and use the profile

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 23, 2016
    Configuration menu
    Copy the full SHA
    cf8b3dc View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2016

  1. Fix invalid standard bootstrap-salt.sh path 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 24, 2016
    Configuration menu
    Copy the full SHA
    e34d4ee View commit details
    Browse the repository at this point in the history

  2. Introduce profiles for testing 

    * virtualbox-deploy-conf won't deploy a script
* virtualbox-minion will do a full deploy with a minion config

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 24, 2016
    Configuration menu
    Copy the full SHA
    cf6ac65 View commit details
    Browse the repository at this point in the history

  3. Make sure HAS_LIBS actually works 

    We should initialize the virtualbox connection straight away to catch any init errors and leave `HAS_LIBS = False`

Otherwise it just might not work
I was getting import errors (VBoxPython)

For now it's OK because we only have a local virtualbox connection but later we might make connections to remote ones

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 24, 2016
    Configuration menu
    Copy the full SHA
    af2e6fb View commit details
    Browse the repository at this point in the history

  4. Import the full salt.utils path + logging 

    The debug log exposed private keys

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 24, 2016
    Configuration menu
    Copy the full SHA
    01396d2 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2016

  1. Redtest to stop and restart a machine multiple times 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Jan 31, 2016
    Configuration menu
    Copy the full SHA
    02488c2 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2016

  1. Revert "Make sure HAS_LIBS actually works" 

    Virtualbox has some weird "singleton" that can only be created once, is destroyed when the VirtualboxManager is destroyed and cannot be created again

Having one singleton per process isn't possible either since multiprocessing wizardry will share the VirtualboxManager instance across the parent and childprocesses.
Creating a singleton per process doesn't seem to work either and just stalls the program.

The HAS_LIBS will therefore be just that "has" and not "has and will work".

This reverts commit af2e6fb.
    @LoveIsGrief
    LoveIsGrief committed Feb 7, 2016
    Configuration menu
    Copy the full SHA
    b8dddf9 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2016

  1. Make script runnable as python ...arg 

    It wouldn't find the correct modules and would crash

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 8, 2016
    Configuration menu
    Copy the full SHA
    e5e86f2 View commit details
    Browse the repository at this point in the history

  2. Force reload of vboxapi 

    When called in subprocesses it would have a tendency of forgetting the sys.path, which was modified by the Virtualbox SDK to find its internal modules
Reloading does that for the subprocesses

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 8, 2016
    Configuration menu
    Copy the full SHA
    555743a View commit details
    Browse the repository at this point in the history

  3. Greentest to stop and restart a machine multiple times 

    We will wait for the session state to unlock before letting exiting the functions (with a timeout of course)

If we don't wait they might still be in a bad session state before the next call. Sadly, that might still be the case as virtualbox decided to introduce "internal" sessions to which we have no access, yet still depend on... yay

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 8, 2016
    Configuration menu
    Copy the full SHA
    7332e3e View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2016

  1. Introduce timeout helper 

    This should help us stop copy-pasting the calculations to let us timeout functions

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 9, 2016
    Configuration menu
    Copy the full SHA
    04c241c View commit details
    Browse the repository at this point in the history

  2. Use wait_for helper in vb_get_network_addresses 

    Simplifies the code

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 9, 2016
    Configuration menu
    Copy the full SHA
    34e673d View commit details
    Browse the repository at this point in the history

  3. Add warning for timed out functions 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 9, 2016
    Configuration menu
    Copy the full SHA
    b8d7ff9 View commit details
    Browse the repository at this point in the history

  4. Use wait_for helper in functions related to starting machines 

    Simplifies the code and tries to wait for the correct session state when starting machines

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 9, 2016
    Configuration menu
    Copy the full SHA
    f48b4f5 View commit details
    Browse the repository at this point in the history

  5. zsh-completion: improve (module|runner).function name retrieval 

    parsing ''salt-call -d'' was pretty errorprone and it finally broke. :D
Documention for some cron.* file.* functions isn't formatted with
leading whitespace, thus are picked up by the completer.

So now the completer parses salt-call sys.list_(runner_|)functions
    @llua
    llua committed Feb 9, 2016
    Configuration menu
    Copy the full SHA
    80dc92d View commit details
    Browse the repository at this point in the history

  6. Adding functions to list available portgroups

    @nmadhok
    nmadhok committed Feb 9, 2016
    Configuration menu
    Copy the full SHA
    42a7593 View commit details
    Browse the repository at this point in the history

  7. Don't power on a machine by default after creation 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 9, 2016
    Configuration menu
    Copy the full SHA
    16067bb View commit details
    Browse the repository at this point in the history

  8. More documentation of utils 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 9, 2016
    Configuration menu
    Copy the full SHA
    f089bba View commit details
    Browse the repository at this point in the history

  9. When creating a machine return a dict 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 9, 2016
    Configuration menu
    Copy the full SHA
    2c82f6f View commit details
    Browse the repository at this point in the history

  10. Make sure we close opened ISessions 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 9, 2016
    Configuration menu
    Copy the full SHA
    78236e2 View commit details
    Browse the repository at this point in the history

  11. Check for running machine before getting guest props 

    Outdated values may be retrieved from machines that aren't running

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 9, 2016
    Configuration menu
    Copy the full SHA
    b17fb0e View commit details
    Browse the repository at this point in the history

  12. A few PEP8 changes 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 9, 2016
    Configuration menu
    Copy the full SHA
    90944bd View commit details
    Browse the repository at this point in the history

  13. Remove some TODOs 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 9, 2016
    Configuration menu
    Copy the full SHA
    484b4e5 View commit details
    Browse the repository at this point in the history

  14. Remove rogue print statement 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 9, 2016
    Configuration menu
    Copy the full SHA
    a1386a1 View commit details
    Browse the repository at this point in the history

  15. Move @skipIf to parent classes 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 9, 2016
    Configuration menu
    Copy the full SHA
    d523b73 View commit details
    Browse the repository at this point in the history

  16. Add minion.kill to modules

    Thayne Harbaugh committed Feb 9, 2016
    Configuration menu
    Copy the full SHA
    63134a3 View commit details
    Browse the repository at this point in the history

  17. Merge pull request saltstack#31055 from llua/zsh-completion 

    zsh-completion: improve (module|runner).function name retrieval
    Mike Place committed Feb 9, 2016
    Configuration menu
    Copy the full SHA
    7dafc6d View commit details
    Browse the repository at this point in the history

  18. Fixing typos, many examples in here still don't work (ex. salt -t 15 … 

    …'*' gpg.create_key throws errors), but some low hanging fruit is fixed.
    Zach Malone committed Feb 9, 2016
    Configuration menu
    Copy the full SHA
    271c446 View commit details
    Browse the repository at this point in the history

  19. Improve minion.kill documentation.

    Thayne Harbaugh committed Feb 9, 2016
    Configuration menu
    Copy the full SHA
    679fb7b View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2016

  1. Fix issue where deploy_kwargs is missing. 

    https://github.com/saltstack/salt/blob/develop/salt/cloud/__init__.py#L2104

expects to be able to find deploy_kwargs in the return dict of

https://github.com/saltstack/salt/blob/develop/salt/cloud/__init__.py#L2089

and

https://github.com/saltstack/salt/blob/develop/salt/cloud/__init__.py#L2114

throws an exception if it can't.
    @jmoore987
    jmoore987 committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    6e7fd1d View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from jmoore987/jmoore987-patch-1 

    Fix issue where deploy_kwargs is missing.
    @jmoore987
    jmoore987 committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    6f27d7a View commit details
    Browse the repository at this point in the history

  3. add support for numCoresPerSocket parameter in vmware driver

    @marnovdm
    marnovdm committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    cf70f06 View commit details
    Browse the repository at this point in the history

  4. Fix documentation for cores_per_socket

    @marnovdm
    marnovdm committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    76b6b51 View commit details
    Browse the repository at this point in the history

  5. Fix copy/paste issue

    @marnovdm
    marnovdm committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    52f06bb View commit details
    Browse the repository at this point in the history

  6. Note added to pyenv docs requiring git.

    @AndreasBackx
    AndreasBackx committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    90c12f5 View commit details
    Browse the repository at this point in the history

  7. Merge pull request saltstack#31077 from marnovdm/feature-vmware-cores… 

    …-per-socket

Add support for numCoresPerSocket parameter in vmware driver
    Mike Place committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    8348356 View commit details
    Browse the repository at this point in the history

  8. Clean up lint error 

    Remove some trailing whitespace.
    @jmoore987
    jmoore987 committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    e421f66 View commit details
    Browse the repository at this point in the history

  9. Merge pull request saltstack#31063 from zmalone/develop 

    Fixing typos,
    Mike Place committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    21997ea View commit details
    Browse the repository at this point in the history

  10. Merge pull request saltstack#31073 from jmoore987/develop 

    Fix issue where deploy_kwargs is missing.
    Mike Place committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    3699e54 View commit details
    Browse the repository at this point in the history

  11. Merge pull request saltstack#31054 from nmadhok/portgroups-list 

    Adding functions to list available port groups in VMware salt-cloud driver
    Mike Place committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    99d2e55 View commit details
    Browse the repository at this point in the history

  12. Merge pull request saltstack#31089 from AndreasBackx/develop 

    Note added to pyenv docs requiring git.
    Mike Place committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    58fd895 View commit details
    Browse the repository at this point in the history

  13. Lint

    Mike Place committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    a52e577 View commit details
    Browse the repository at this point in the history

  14. Merge pull request saltstack#31101 from cachedout/lint_31060 

    Lint 31060
    Mike Place committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    e2a081b View commit details
    Browse the repository at this point in the history

  15. Herp derp frist!

    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    849858b View commit details
    Browse the repository at this point in the history

  16. Add more bones to the create() function skeleton

    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    7e32531 View commit details
    Browse the repository at this point in the history

  17. Simple tests to get a feel of the virtualbox api 

    These aren't unit tests (yet)
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    bc929b4 View commit details
    Browse the repository at this point in the history

  18. The Virtualbox SDK ref 

    No need to go online and search for it
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    4869d75 View commit details
    Browse the repository at this point in the history

  19. Got a README, mate?

    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    b8f66fa View commit details
    Browse the repository at this point in the history

  20. A little more documentation 

    Also get rid of keys we don't need in the provider config
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    492b684 View commit details
    Browse the repository at this point in the history

  21. Only allow us to clone VMs (for now)

    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    2043157 View commit details
    Browse the repository at this point in the history

  22. Fill the virtual name for salt-cloud

    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    182a31f View commit details
    Browse the repository at this point in the history

  23. Debug line: is virtualbox configured for salt-cloud?

    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    24e6262 View commit details
    Browse the repository at this point in the history

  24. Use correct variable (copy-pasted from linode.py :\

    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    09ad1e8 View commit details
    Browse the repository at this point in the history

  25. Logs to let the user know why stuff fails

    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    a129233 View commit details
    Browse the repository at this point in the history

  26. PEP8 linting

    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    2d23c84 View commit details
    Browse the repository at this point in the history

  27. Move out basic virtualbox functions and introduce basic tests

    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    22e5936 View commit details
    Browse the repository at this point in the history

  28. Ignore pycharm files

    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    516a242 View commit details
    Browse the repository at this point in the history

  29. Fix some lint errors

    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    330e4c7 View commit details
    Browse the repository at this point in the history

  30. We need a pass

    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    e2cbe83 View commit details
    Browse the repository at this point in the history

  31. Make the logs a little clearer

    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    9e3ff6c View commit details
    Browse the repository at this point in the history

  32. Create a basic VirtualBoxTestCase with helper assertions

    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    ed76f64 View commit details
    Browse the repository at this point in the history

  33. Introduce a method to help us create VMs 

    (not clones)
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    47ae6e2 View commit details
    Browse the repository at this point in the history

  34. Improve tests 

    Test VM creation, destruction and cloning
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    c07cd63 View commit details
    Browse the repository at this point in the history

  35. De-linting

    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    0328673 View commit details
    Browse the repository at this point in the history

  36. Ignore the log directory created by tests

    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    b1faa8f View commit details
    Browse the repository at this point in the history

  37. Moar information

    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    8b7a691 View commit details
    Browse the repository at this point in the history

  38. Post-merge organization

    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    c4cb16c View commit details
    Browse the repository at this point in the history

  39. Add basic configuration for the tests 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    b9ec577 View commit details
    Browse the repository at this point in the history

  40. Move around files for clarity and separation 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    4a1a6a9 View commit details
    Browse the repository at this point in the history

  41. Setup testing for calls to salt-cloud 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    1545c9d View commit details
    Browse the repository at this point in the history

  42. PEP8 docstrings 

    double quotes instead of single quotes

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    1995b9a View commit details
    Browse the repository at this point in the history

  43. Add virtualbox to profile checks 

    Virtualbox needs the 'clonefrom' property and it doesn't need size

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    98ad2cb View commit details
    Browse the repository at this point in the history

  44. Remove unnecessary import 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    2342940 View commit details
    Browse the repository at this point in the history

  45. More rigorous setup precautions for tests 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    459eaa8 View commit details
    Browse the repository at this point in the history

  46. Set default log level to INFO 

    Fix log lines

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    50c36b0 View commit details
    Browse the repository at this point in the history

  47. Use the constants for testing 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    df789ae View commit details
    Browse the repository at this point in the history

  48. Return a dict from an XPCOM object 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    c39ec47 View commit details
    Browse the repository at this point in the history

  49. Unit tests for xpcomt to dict conversion 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    8009f3b View commit details
    Browse the repository at this point in the history

  50. A log line y'all! 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    e02bc0e View commit details
    Browse the repository at this point in the history

  51. Test creating a virtual machine with salt-cloud 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    14b5e9b View commit details
    Browse the repository at this point in the history

  52. Make creating a virtual machine work 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    0099b94 View commit details
    Browse the repository at this point in the history

  53. Code formatting 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    5b9f99a View commit details
    Browse the repository at this point in the history

  54. Check existence without an exception 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    3a27c9b View commit details
    Browse the repository at this point in the history

  55. move vbox to its own function 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    16f44f4 View commit details
    Browse the repository at this point in the history

  56. Organize imports a little 

    This will allow us to import the provider in e.g a virtualenv without doing too much PYTHONPATH fuckery

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    d3103e1 View commit details
    Browse the repository at this point in the history

  57. List all available images in virtualbox 

    Does virtualbox have templates?

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    00229e2 View commit details
    Browse the repository at this point in the history

  58. Move virtualbox functions to their own utility module 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    38526b2 View commit details
    Browse the repository at this point in the history

  59. Implement instance destruction 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    f4094ae View commit details
    Browse the repository at this point in the history

  60. Oops, that doesn't belong there... 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    4cb228a View commit details
    Browse the repository at this point in the history

  61. Remove some TODOs 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    c70df10 View commit details
    Browse the repository at this point in the history

  62. Remove list_available_images 

    Following a discussion about it, the function just doesn't apply to virtualbox
virtalbox doesn't have a concept of "templates" so we can't list them

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    ec50b5c View commit details
    Browse the repository at this point in the history

  63. Ignore test log files 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    5867b82 View commit details
    Browse the repository at this point in the history

  64. Ignore private keys generated by integration tests 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    43fff23 View commit details
    Browse the repository at this point in the history

  65. Improve XPCOM to dict conversion 

    We will need this in the future when listing machines and requesting attributes that don't exist (yet)

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    2439d61 View commit details
    Browse the repository at this point in the history

  66. Improve XPCOM to dict conversion 

    Allow passing tuples of attributes and their default values in case they don't exist in the xpcom object

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    20b574a View commit details
    Browse the repository at this point in the history

  67. Output the default information expected for list_nodes 

    This still needs to be enriched

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    abf139a View commit details
    Browse the repository at this point in the history

  68. A small TODO 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    b859312 View commit details
    Browse the repository at this point in the history

  69. Improve the output of list_nodes 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    8c7e885 View commit details
    Browse the repository at this point in the history

  70. Tests and templates for starting and stopping VMs 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    f4386c9 View commit details
    Browse the repository at this point in the history

  71. Output a human-readable machine state 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    f8abd87 View commit details
    Browse the repository at this point in the history

  72. Red-test: list_nodes_full 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    a1c94bf View commit details
    Browse the repository at this point in the history

  73. Green-test: list_nodes_full 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    acd8736 View commit details
    Browse the repository at this point in the history

  74. Implement function show_image 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    3b05221 View commit details
    Browse the repository at this point in the history

  75. Refactoring and code clean up 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    ebd94d8 View commit details
    Browse the repository at this point in the history

  76. Implement list_nodes_select 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    b0752a3 View commit details
    Browse the repository at this point in the history

  77. A little PEP8 cleaning 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    13d4927 View commit details
    Browse the repository at this point in the history

  78. A simpler version of list_nodes_select 

    Reuse helper

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    4bcd687 View commit details
    Browse the repository at this point in the history

  79. First version to get network adresses from guest 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    cd0d638 View commit details
    Browse the repository at this point in the history

  80. Use dict output for VirtualboxTests 

    This should make the output from salt-cloud more verifiable and make tests more reliable

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    b195d0f View commit details
    Browse the repository at this point in the history

  81. First test to get network address from already running guest 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    1b3d96f View commit details
    Browse the repository at this point in the history

  82. Move some common test functions to helpers 

    Introduce stop machine test (it's red :( )

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    04c3bae View commit details
    Browse the repository at this point in the history

  83. Provider is getting deprecated in the config 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    59d212a View commit details
    Browse the repository at this point in the history

  84. Force actions in tests 

    Otherwise there is always a confirmation prompt... ain't nobody got time fo' dat!

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    8111dcb View commit details
    Browse the repository at this point in the history

  85. Green-test: VirtualboxProviderHeavyTests::test_stop_action 

    We can now tell instances to stop

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    8604be6 View commit details
    Browse the repository at this point in the history

  86. Use common function to output machines 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    48b1b37 View commit details
    Browse the repository at this point in the history

  87. A function doc 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    f9b993e View commit details
    Browse the repository at this point in the history

  88. Starting machines works now too 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    1d6b94c View commit details
    Browse the repository at this point in the history

  89. Try and stop the running VM as a cleanup 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    7c4b358 View commit details
    Browse the repository at this point in the history

  90. Remove unneeded test 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    ef24a16 View commit details
    Browse the repository at this point in the history

  91. Improve documentation a little and fix warnings 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    64411a2 View commit details
    Browse the repository at this point in the history

  92. Get real number of slots for VM 

    Before it was theoretical, now it's real (a response from a query the VM, not the hypervisor settings)

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    6fb7161 View commit details
    Browse the repository at this point in the history

  93. Helper functions should do what they are named for 

    New helpers also added to describe the state of the machine

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    f56d72b View commit details
    Browse the repository at this point in the history

  94. New function for ip addresses 

    Waits on the guest to have one.

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    63edda4 View commit details
    Browse the repository at this point in the history

  95. Improve output JSON interpretation cleaning for tests 

    (Actually also fix it because we we popping increasing random elements from the output... not good)

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    7b4142d View commit details
    Browse the repository at this point in the history

  96. Improve doc 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    ef92ba9 View commit details
    Browse the repository at this point in the history

  97. Feature: deploy salt on machine when creating 

    We need to setup the tests with a profile that wants to deploy and use the profile

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    1a8cd74 View commit details
    Browse the repository at this point in the history

  98. Fix invalid standard bootstrap-salt.sh path 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    152a190 View commit details
    Browse the repository at this point in the history

  99. Introduce profiles for testing 

    * virtualbox-deploy-conf won't deploy a script
* virtualbox-minion will do a full deploy with a minion config

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    6cfb447 View commit details
    Browse the repository at this point in the history

  100. Make sure HAS_LIBS actually works 

    We should initialize the virtualbox connection straight away to catch any init errors and leave `HAS_LIBS = False`

Otherwise it just might not work
I was getting import errors (VBoxPython)

For now it's OK because we only have a local virtualbox connection but later we might make connections to remote ones

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    a98891a View commit details
    Browse the repository at this point in the history

  101. Import the full salt.utils path + logging 

    The debug log exposed private keys

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    d09e45a View commit details
    Browse the repository at this point in the history

  102. Redtest to stop and restart a machine multiple times 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    95ab352 View commit details
    Browse the repository at this point in the history

  103. Revert "Make sure HAS_LIBS actually works" 

    Virtualbox has some weird "singleton" that can only be created once, is destroyed when the VirtualboxManager is destroyed and cannot be created again

Having one singleton per process isn't possible either since multiprocessing wizardry will share the VirtualboxManager instance across the parent and childprocesses.
Creating a singleton per process doesn't seem to work either and just stalls the program.

The HAS_LIBS will therefore be just that "has" and not "has and will work".

This reverts commit af2e6fb.
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    12a638a View commit details
    Browse the repository at this point in the history

  104. Make script runnable as python ...arg 

    It wouldn't find the correct modules and would crash

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    5a55f8a View commit details
    Browse the repository at this point in the history

  105. Force reload of vboxapi 

    When called in subprocesses it would have a tendency of forgetting the sys.path, which was modified by the Virtualbox SDK to find its internal modules
Reloading does that for the subprocesses

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    9323514 View commit details
    Browse the repository at this point in the history

  106. Greentest to stop and restart a machine multiple times 

    We will wait for the session state to unlock before letting exiting the functions (with a timeout of course)

If we don't wait they might still be in a bad session state before the next call. Sadly, that might still be the case as virtualbox decided to introduce "internal" sessions to which we have no access, yet still depend on... yay

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    24da4ea View commit details
    Browse the repository at this point in the history

  107. Introduce timeout helper 

    This should help us stop copy-pasting the calculations to let us timeout functions

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    6611429 View commit details
    Browse the repository at this point in the history

  108. Use wait_for helper in vb_get_network_addresses 

    Simplifies the code

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    c05b6f1 View commit details
    Browse the repository at this point in the history

  109. Add warning for timed out functions 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    a59336f View commit details
    Browse the repository at this point in the history

  110. Use wait_for helper in functions related to starting machines 

    Simplifies the code and tries to wait for the correct session state when starting machines

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    ef0a26b View commit details
    Browse the repository at this point in the history

  111. Don't power on a machine by default after creation 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    5de7cee View commit details
    Browse the repository at this point in the history

  112. More documentation of utils 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    6149e3e View commit details
    Browse the repository at this point in the history

  113. When creating a machine return a dict 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    53c7cd8 View commit details
    Browse the repository at this point in the history

  114. Make sure we close opened ISessions 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    2dd3580 View commit details
    Browse the repository at this point in the history

  115. Check for running machine before getting guest props 

    Outdated values may be retrieved from machines that aren't running

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    dab2356 View commit details
    Browse the repository at this point in the history

  116. A few PEP8 changes 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    fc0b268 View commit details
    Browse the repository at this point in the history

  117. Remove some TODOs 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    54db49b View commit details
    Browse the repository at this point in the history

  118. Remove rogue print statement 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    002ce06 View commit details
    Browse the repository at this point in the history

  119. Move @skipIf to parent classes 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    e5f8227 View commit details
    Browse the repository at this point in the history

  120. Move risky event into try/except 

    It might leave the test env in a dirty state, maybe further tests might fail, but we have the log to trace it back to that

Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    17735df View commit details
    Browse the repository at this point in the history

  121. Merge remote-tracking branch 'origin/salt-27089' into salt-27089 

    Conflicts:
	.gitignore
	salt/config/__init__.py
	tests/integration/cloud/providers/virtualbox.py
    @LoveIsGrief
    LoveIsGrief committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    69968f7 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2016

  1. Attempt to fix pylint errors and warnings 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 11, 2016
    Configuration menu
    Copy the full SHA
    4eab39e View commit details
    Browse the repository at this point in the history

  2. Attempt to fix more pylint errors and warnings 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 11, 2016
    Configuration menu
    Copy the full SHA
    7965eaa View commit details
    Browse the repository at this point in the history

  3. Lint

    Mike Place committed Feb 11, 2016
    Configuration menu
    Copy the full SHA
    52f6887 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2016

  1. Merge pull request #1 from cachedout/lint_31058 

    Lint
    @LoveIsGrief
    LoveIsGrief committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    bbe513e View commit details
    Browse the repository at this point in the history

  2. Remove unused function 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    3cd04cb View commit details
    Browse the repository at this point in the history

  3. from ... import ... on top for lint? 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    bb6ffa8 View commit details
    Browse the repository at this point in the history

  4. Fix python3 pylint error 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    a944c5d View commit details
    Browse the repository at this point in the history

  5. Remove unused param 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    6704ad3 View commit details
    Browse the repository at this point in the history

  6. Add a little more information to the heavy virtualbox tests 

    Related to saltstack#27089 Saltcloud virtualbox provider
    @LoveIsGrief
    LoveIsGrief committed Feb 12, 2016
    Configuration menu
    Copy the full SHA
    04795b1 View commit details
    Browse the repository at this point in the history