Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #30217 - was causing salt-cloud -a breakage #31061

Merged
merged 1 commit into from Feb 10, 2016

Conversation

rallytime
Copy link
Contributor

Reverts #30217

Fixes #30950 and #31059

@nmadhok
Copy link
Contributor

nmadhok commented Feb 9, 2016

@rallytime Can you also include the changes to the VMware cloud driver that were suggested originally?

@rallytime
Copy link
Contributor Author

@nmadhok I'd rather not right now, as we're trying to get a release out, and the less churn we have for that release, the better. I tested the functions in question, and they're working just fine with only this change. I can address the other changes in another pull request.

Here's the output of those functions, running on this branch:

# salt-cloud -a create_snapshot test_ub14 snapshot_name="snap-test-1" -y
[INFO    ] salt-cloud starting
[INFO    ] [ test_ub14 ] Waiting for create snapshot task to finish [0 s]
[INFO    ] [ test_ub14 ] Successfully completed create snapshot task in 3 seconds
vmware-config:
    ----------
    vmware:
        ----------
        test_ub14:
            ----------
            Snapshot created successfully:
                ----------
                created:
                    2016-02-09 14:28:02
                description:
                name:
                    snap-test-1
                path:
                    /Test3cloud/Test3cloud/Test4cloud/Test4cloud/mySnapshot/mySnapshot/snap-test-1/snap-test-1
                state:
                    poweredOff
root@vagrant-ubuntu-trusty-64:~# salt-cloud -a revert_to_snapshot test_ub14 power_off=True
[INFO    ] salt-cloud starting
The following virtual machines are set to be actioned with "revert_to_snapshot":
  test_ub14

Proceed? [N/y] y
... proceeding
[INFO    ] [ test_ub14 ] Waiting for revert to snapshot task to finish [0 s]
[INFO    ] [ test_ub14 ] Successfully completed revert to snapshot task in 3 seconds
vmware-config:
    ----------
    vmware:
        ----------
        test_ub14:
            reverted to current snapshot

Reverts commit 1f68ce0.
Reverts commit 5264449.

Conflicts:
	salt/runners/cloud.py
cachedout pushed a commit that referenced this pull request Feb 10, 2016
Revert #30217 - was causing salt-cloud -a breakage
@cachedout cachedout merged commit 4d6706b into saltstack:2015.8 Feb 10, 2016
@rallytime rallytime deleted the revert-breakage branch February 10, 2016 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants