Add password support for zip files in archive module and state #31116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zipfile should be there. This decorator appears to fail on Windows. The function works fine without the decorator
| @@ -560,7 +570,7 @@ def unzip(zip_file, dest, excludes=None, | |||
| source = zfile.read(target) | |||
| os.symlink(source, os.path.join(dest, target)) | |||
| continue | |||
| zfile.extract(target, dest) | |||
| zfile.extract(target, dest, password) | |||
There was a problem hiding this comment.
I tested this to see what would happen if password=None and it seems to extract without a problem. So we're good!
cachedout
pushed a commit
that referenced
this pull request
Feb 11, 2016
Add password support for zip files in archive module and state
rallytime
added
the
ZZZ[Done]-back-ported-bf
|
@UtahDave That same decorator is there on the zip_ function and probably doesn't work in windows either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add password support for zip files in archive module and state
Fixes: #26569
ZD 408