Rework tests and fix reverse peering with gluster 3.7 #31287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reworked the test structure design for the gluster module and state so I could create a test that mimiced the behavior difference between 3.7 and prior versions when reverse probing by ip a server that already exists. Added the additional data given by gluster 3.7 to the output of glusterfs.list_peers to allow us to compare a requested peering against a host's aliases. Fixes saltstack#30932
joejulian
force-pushed
the
2015.8_30932_peer_probe_by_ip
branch
from
99313f8
to
783e9b2
Compare
|
@joejulian Thanks! @gtmanfred You want to jump in here? I know you keep an eye on the gluster support. |
|
+1 to this one |
|
@gtmanfred Thanks! @joejulian If the tests pass, I'll get this merged. Thank you! |
|
They all passed, just not at the same time. If only there was a tool that could bootstrap those VMs... ;) |
cachedout
pushed a commit
that referenced
this pull request
Feb 18, 2016
Rework tests and fix reverse peering with gluster 3.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked the test structure design for the gluster module and state so I
could create a test that mimiced the behavior difference between 3.7 and
prior versions when reverse probing by ip a server that already exists.
Added the additional data given by gluster 3.7 to the output of
glusterfs.list_peers to allow us to compare a requested peering against
a host's aliases.
Fixes #30932