Fix dunder virtual to check for Remote Administration Tools #31292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be fine, but for future reference please separate formatting PRs from bug fixes. It's very time-consuming to review formatting changes for regressions. ;] Thanks. |
| python_shell=True) | ||
| return not __salt__['cmd.retcode']('Import-Module ServerManager', | ||
| shell='powershell', | ||
| python_shell=True) |
There was a problem hiding this comment.
Why is python_shell set to True here?
There was a problem hiding this comment.
@cachedout The powershell command requires python_shell=True. The functions have been using cmd_quote on passed parameters for this reason.
There was a problem hiding this comment.
K. I wasn't aware of that. Thanks for letting me know.
cachedout
added
the
Pending-Discussion
cachedout
pushed a commit
that referenced
this pull request
Feb 18, 2016
Fix dunder virtual to check for Remote Administration Tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Install and Uninstall functions
Fix overly long lines (>80 chars)
Improved documentation
#30350