[dockerng ] Detect settings removal #31326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When removing settings from dockerng.running state definition, changes where ignored as `_compare()` was iterating only over user defined parameters. By looping over all available options we are now sure to not miss removed entries. Extend definition of expected default values: - Some default values are predictable and hardcoded in the VALID_CREATE_OPTS dict. - Some default needs to be read from images (`image_path`) - Some defaults values are unpredictable (hostname, mac_address) we are comparing desired value against value reported by the container (`get_default_from_container`).
cachedout
pushed a commit
that referenced
this pull request
Feb 18, 2016
…s-removal [dockerng ] Detect settings removal
ticosax
added a commit
to ticosax/salt
that referenced
this pull request
Feb 19, 2016
ports will most likely be defined as integer
This was referenced Feb 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removing settings from
dockerng.runningstate definition,changes where ignored as
_compare()was iterating only over user definedparameters.
By looping over all available options we are now sure to not miss
removed entries.
Extend definition of expected default values:
image_path)we are comparing desired value against value reported by the container
(
get_default_from_container)./cc @terminalmage