Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zypper refresh handling #31378

Merged
merged 4 commits into from
Feb 22, 2016
Merged

Conversation

mcalmer
Copy link
Contributor

@mcalmer mcalmer commented Feb 20, 2016

clarify and unify zypper refresh handling.

Requesting refresh is a force refresh. If not forcing refresh, we let zypper decide if a refresh is needed or not.

In the meanwhile zypper has for all refresh operations a threshold to prevent useless refreshes. It would be good to trust zypper here.

@isbm : maybe you want to check this again.

@mcalmer
Copy link
Contributor Author

mcalmer commented Feb 21, 2016

@isbm : please check the new commit.

@isbm
Copy link
Contributor

isbm commented Feb 21, 2016

@mcalmer Just a nitpick: if I just checking the value, I would use get() function on the dict instead of pop(), which is modifying it. But if you want to modify it, sure.

Other then that, 👍 💚

@cachedout
Copy link
Contributor

Thanks for your work here @mcalmer and for your excellent feedback, @isbm.

This looks good enough to merge for now so I'm going to go ahead and get it in. Thanks.

cachedout pushed a commit that referenced this pull request Feb 22, 2016
@cachedout cachedout merged commit 83294e4 into saltstack:2015.8 Feb 22, 2016
@mcalmer mcalmer deleted the zypper-refresh-handling branch March 1, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants