Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Test for Zypper's "remove" and "purge" #31488

Merged
merged 3 commits into from Feb 25, 2016

Conversation

isbm
Copy link
Contributor

@isbm isbm commented Feb 25, 2016

What does this PR do?

Implements Unit Tests for Zypper's remove() and purge()

What issues does this PR fix or reference?

Refactors code a bit, fixes a docstring.

Previous Behavior

Does the job.

New Behavior

Still does the job, just tested. 馃槈

Tests written?

[x] Yes
[ ] No

@isbm isbm changed the title Isbm zypper ut removepurge Unit Test for Zypper's "remove" and "purge" Feb 25, 2016
@cachedout
Copy link
Contributor

Hi @isbm Typically, a PR like this would go into the develop branch. However, in this case, since the new code is providing additional test coverage for the branch, I'm going to make an exception and put it in the point release. Thanks.

cachedout pushed a commit that referenced this pull request Feb 25, 2016
Unit Test for Zypper's "remove" and "purge"
@cachedout cachedout merged commit e68a094 into saltstack:2015.8 Feb 25, 2016
@isbm
Copy link
Contributor Author

isbm commented Feb 25, 2016

@cachedout The develop branch is quite diverged from the 2015.8... Still, what do you mean? I will write some more tests for the Zypper and PR them exactly against this branch. Should I do something else?

@isbm isbm deleted the isbm-zypper-ut-removepurge branch February 26, 2016 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants