Handling error from using gevent 1.1. #31627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was just looking at the issue that this references. Frankly, this strikes me as an upstream bug in gevent but this is a totally reasonable workaround from the salt side. |
|
I agree.. gevent should be better about backwards compatibility.. but it would be a shame to have it break salt so badly when it doesn't have to. |
|
Yes, certainly. I agree. |
cachedout
pushed a commit
that referenced
this pull request
Mar 2, 2016
Handling error from using gevent 1.1.
|
Merged. Thanks, @jakehilton |
|
Thank you for the merge @cachedout . Do you know by chance if it will make it into the next release? |
|
@jakehilton Yes, this will make it into the next release, which will be 2015.8.8. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Handles another error case when refreshing modules.
What issues does this PR fix or reference?
Fixes runs to work with gevent 1.1 Ticket: #31009
Previous Behavior
Halt execution so that package management fails.
New Behavior
Logs the error but continues execution.
Tests written?