Don't attempt to verify token if it wasn't sent to master. #31653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In multimaster setup new minion having no master pubkey sends initial auth requests to each master without token but it tries to verify the token in the received payload for each master excluding the first. This happens because minion makes this decision depending on the master pubkey file existense.
|
@DmitryKuzmenko @cachedout This looks good to me, it should only be invoked in the right cases. |
cachedout
pushed a commit
that referenced
this pull request
Mar 3, 2016
…th_fail Don't attempt to verify token if it wasn't sent to master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make minion to remember have it sent token to the master in auth request and don't attempt to verify the token if not.
What issues does this PR fix or reference?
Fixes #29753
Previous Behavior
In multimaster setup when a new minion have no master pubkey it sends the async auth request to each master withouth minion token. So each master answers without the token.
When minion handles the answers it verifies the minion token if master pubkey file exists. After the first answer minion writes master pubkey into the file and decides the answer have to contain the token when handles other answers.
New Behavior
For each master auth reply minion checks did it send the token to master and doesn't verify it if not.
Tests written?