[dockerng] Fix dockerng.network_present when container is given by name #31713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because docker inspect network returns attached containers by their Ids.
cachedout
pushed a commit
that referenced
this pull request
Mar 7, 2016
…ner_id [dockerng] Fix dockerng.network_present when container is given by name
|
Thanks, @ticosax |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
dockerng.network_presentcheck if given list of containers are already bound to a network. Anddockerng.network_presentexpect containers to be given by ID, so we swap all names with their IDs, before performing comparison.What issues does this PR fix or reference?
none
Previous Behavior
The container was repeatedly attached to the network.
New Behavior
Act only on difference of configuration.
Tests written?