file_ignore_regex is a list, not bool #31723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 7, 2016
|
Can one of the admins verify this patch? |
|
Go Go Jenkins! |
rallytime
pushed a commit
that referenced
this pull request
Mar 9, 2016
file_ignore_regex is a list, not bool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Alternative to #31707 which fixes part of #31563, master_tops is already fixed in 2015.8.
This is also present in 2016.3 (causing issues in my setup ATM) and develop so this needs to be forward-merged to those branches.
What issues does this PR fix or reference?
Fixes part of #31563
Previous Behavior
See ##31563
New Behavior
Not complaining as the type is now correct for file_ignore_regex
Tests written?
Notes
Limited testing, as I can't use 2015.8 very well on illumos.