Fix influxdb user functionality for version 0.9+ #31770
Conversation
- get_list_cluster_admins no longer exists - user dict keys changed
|
Go Go Jenkins! |
| if username == name: | ||
| return True | ||
| else: | ||
| log.warning('Could not find username in user: %s', user) |
There was a problem hiding this comment.
Is it intended to warn on every single user in the users list? This seems a little noisy. Would it make more sense to move this out of the loop and warn at the end if we haven't returned already?
There was a problem hiding this comment.
I think the log.warning should really never happen, which is why I didn't put much thought into whether to put it in the loop or not. In InfluxDB 0.8, user.get('name') will return the username, and in 0.9+, user.get('user') will return the username. I don't know how 0.7 would behave.
If I put the log outside of the loop, I wouldn't be able to log the user dict that doesn't contain the expected keys, and I'd have to add an additional variable - found_missing_user_keys or something.
There was a problem hiding this comment.
Ah, ok. Sounds good. I didn't realize the else statement would likely never occur. Thanks for the explanation!
rallytime
added
Pending-Discussion
Fix influxdb user functionality for version 0.9+
Fixes #30489