win_dacl state & module: return comment field as strings, not lists. #31779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sbreidba Excellent. Thanks! |
rallytime
added
the
bugfix-bckport
rallytime
pushed a commit
that referenced
this pull request
Mar 10, 2016
win_dacl state & module: return comment field as strings, not lists.
|
Whew - I wasn't sure what was going on with the build errors regarding tornado.ioloop... |
|
@sbreidba Yeah, we're working on some PR test upgrades on our Jenkins server, and we're running the tests (old and new) in parallel so we can work out any kinks. So you're all good here! :) |
rallytime
removed
the
bugfix-bckport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This alters the win_dacl state and module to return the 'comment' field as a string instead of a list, as per the state requirements.
What issues does this PR fix or reference?
Addresses issue #31772.
Previous Behavior
The state function comment returns were lists. This caused state/highstate output to appear as YAML.
New Behavior
State function comment returns are now strings, and state/highstate output appears normal (highstate format).
Tests written?