Prevent event logs from writing huge amounts of data #31818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anlutro This looks like a good change to me, but I'd like @cachedout to review this as well, before merging. Also, there's a small pylint error that needs to be cleaned up in the mean time. |
rallytime
added
the
Pending-Discussion
- don't log event data on returner not found - only log event data if log_level is debug or lower
|
This is good. Thanks, @anlutro |
cachedout
pushed a commit
that referenced
this pull request
Mar 14, 2016
Prevent event logs from writing huge amounts of data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in issue #28357 - this PR does not fix the issue entirely!
Changes made: