Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now a check_file_meta deletes temporary files when test=True #31845

Merged
merged 1 commit into from Mar 15, 2016
Merged

Now a check_file_meta deletes temporary files when test=True #31845

merged 1 commit into from Mar 15, 2016

Conversation

sakateka
Copy link
Contributor

What does this PR do?

fix check_file_meta that it deletes temporary files when test = True

Tests written?

  • Yes
  • No

@cachedout
Copy link
Contributor

HI @sakateka

You mention in your description that this should only delete temporary files when test=True but I don't see this wrapped in a conditional for testing mode at all. Could you please clarify? Perhaps I'm just missing something obvious. :]

@cachedout cachedout added the Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged label Mar 14, 2016
@sakateka
Copy link
Contributor Author

To be precise, this function will always leave temporary files, but I saw a problem only when launched highstate test=True.
state example

/tmp/test.file:
  file.managed:
    - contents: |
        test contents

state file.managed call file.check_managed_changes and it call check_file_meta

cachedout pushed a commit that referenced this pull request Mar 15, 2016
Now a check_file_meta deletes temporary files when test=True
@cachedout cachedout merged commit ffd65c3 into saltstack:2015.8 Mar 15, 2016
@cachedout
Copy link
Contributor

Gotcha. Thanks for the clarification.

@sakateka sakateka deleted the check_file_meta_clean_tmp branch March 16, 2016 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants